Repository navigation
fix(server-lifecycle): 收口合服 PR974 CodeRabbit 快修项 - #985
Merged
Merged
Conversation
- OnlineServerAnchorMergeParticipant:前置校验目标服锚点,已合入其他服(退役服)直接拒绝,避免数据写入已退役区服 - OnlineServerRowKeyRewriteParticipant:真实执行 CAS 重试耗尽(skipped>0)时抛 StateOperationForbidden 拒绝落定,重试按 HomeServerId 过滤补写滞留行 - OnlineServerMergeCli:解析阶段拒绝非正数源区服 ID,返回参数错误码 2 而非业务拒绝码 3 - 新增回归测试:目标服退役拒绝、skipped 拒绝落定(1120 通过)
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 29 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. CodeRabbit Verify
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



概要
收口 PR #974 CodeRabbit 审查中 Quick win 级 Major/Minor 遗留项:
OnlineServerAnchorMergeParticipant前置校验目标服锚点——目标服已合入其他服(退役)时整体拒绝(StateOperationForbidden),dry-run 即暴露,避免源服数据经行键重写落入已退役区服。OnlineServerRowKeyRewriteParticipant真实执行时 skipped>0 抛StateOperationForbidden,计划不落定;重试按HomeServerId == 源服过滤补写滞留行,对账明细语义不变。--sources=0/-1,返回参数错误码 2。已修过不重复处理:provider 非法值报错(9bc87108)、事件补发记账(a294067f)、用法说明等号格式(eae16ee 起)。
遗留(已入 backlog)
测试
MergeAsync_TargetServerAlreadyMerged_RejectedInDryRun、MergeAsync_RowRewriteSkippedRows_ThrowsAndRefusesToSettledotnet build0 错误