fix(SurfaceMeshInspection): Inspector to compute negative polygons wa…

[MelchiorSchuh]

…s not called for surface meshes not in sections

[github-actions]

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v20.1.8) reports: 6 concern(s)

• include/geode/inspector/criterion/negative_elements/surface_negative_elements.hpp:42:45: warning: [cppcoreguidelines-special-member-functions]

  class 'SurfaceMeshNegativeElements' defines a destructor, a copy constructor and a copy assignment operator but does not define a move constructor or a move assignment operator

     42 |     class opengeode_inspector_inspector_api SurfaceMeshNegativeElements
        |                                             ^

• include/geode/inspector/surface_inspector.hpp:82:11: warning: [cppcoreguidelines-special-member-functions]

  class 'SurfaceMeshInspector' defines a default destructor, a copy constructor and a copy assignment operator but does not define a move constructor or a move assignment operator

     82 |     class SurfaceMeshInspector : public AddInspectors< SurfaceMesh< dimension >,
        |           ^

• include/geode/inspector/surface_inspector.hpp:94:9: warning: [google-explicit-constructor]

  single-argument constructors must be marked explicit to avoid unintentional implicit conversions

     94 |         SurfaceMeshInspector( const SurfaceMesh< dimension >& mesh );
        |         ^
        |         explicit 

• src/geode/inspector/criterion/negative_elements/surface_negative_elements.cpp:43:9: warning: [google-explicit-constructor]

  single-argument constructors must be marked explicit to avoid unintentional implicit conversions

     43 |         Impl( const SurfaceMesh< dimension >& mesh ) : mesh_( mesh ) {}
        |         ^
        |         explicit 

• src/geode/inspector/criterion/negative_elements/surface_negative_elements.cpp:45:9: warning: [modernize-use-nodiscard]

  function 'mesh_has_negative_elements' should be marked [[nodiscard]]

     45 |         bool mesh_has_negative_elements() const
        |         ^
        |         [[nodiscard]] 

• src/geode/inspector/criterion/negative_elements/surface_negative_elements.cpp:61:9: warning: [modernize-use-nodiscard]

  function 'negative_polygons' should be marked [[nodiscard]]

     61 |         InspectionIssues< index_t > negative_polygons() const
        |         ^
        |         [[nodiscard]] 

Have any feedback or feature suggestions? Share it here.

[BotellaA]

🎉 This PR is included in version 6.8.20-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[BotellaA]

🎉 This PR is included in version 6.8.20 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀