Fix/explicit variability

include/geode/basic/attribute_manager.hpp

@@ -41,7 +41,7 @@
      * This class manages all its associated Attributes.
      * Each Attribute is registered and can be retrieved by a given name.
      */
     class opengeode_basic_api AttributeManager
     {
         OPENGEODE_DISABLE_COPY( AttributeManager );
 
@@ -60,7 +60,7 @@
         [[nodiscard]] std::shared_ptr< AttributeBase > find_generic_attribute(
             std::string_view name ) const
         {
-            absl::ReaderMutexLock lock{ &mutex() };
+            absl::ReaderMutexLock lock{ mutex() };
             return find_attribute_base( name );
         }
 
@@ -74,7 +74,7 @@
         [[nodiscard]] std::shared_ptr< ReadOnlyAttribute< T > > find_attribute(
             std::string_view name ) const
         {
-            absl::ReaderMutexLock lock{ &mutex() };
+            absl::ReaderMutexLock lock{ mutex() };
             auto attribute =
                 std::dynamic_pointer_cast< ReadOnlyAttribute< T > >(
                     find_attribute_base( name ) );
@@ -110,7 +110,7 @@
             AttributeProperties properties )
         {
             {
-                absl::ReaderMutexLock lock{ &mutex() };
+                absl::ReaderMutexLock lock{ mutex() };
                 auto attribute = find_attribute_base( name );
                 auto typed_attribute =
                     std::dynamic_pointer_cast< Attribute< T > >( attribute );
@@ -119,7 +119,7 @@
                     return typed_attribute;
                 }
             }
-            absl::MutexLock lock{ &mutex() };
+            absl::MutexLock lock{ mutex() };
             auto attribute = find_attribute_base( name );
             auto typed_attribute =
                 std::dynamic_pointer_cast< Attribute< T > >( attribute );
@@ -265,7 +265,7 @@
         template < typename Archive >
         void serialize( Archive& archive );
 
         absl::Mutex& mutex() const;
 
         /*!
          * Find the Attribute associated with the given name

include/geode/basic/cached_value.hpp

@@ -35,26 +35,26 @@
 namespace geode
 {
     template < typename ReturnType >
     class CachedValue
     {
     public:
         template < typename... Args >
         using CachedFunction =
             typename std::add_pointer< ReturnType( Args... ) >::type;
 
         CachedValue() = default;
         CachedValue( const CachedValue& other )
         {
             value_ = other.value_;
             computed_ = other.computed_.load();
         }
         CachedValue( CachedValue&& other ) noexcept
         {
             value_ = std::move( other.value_ );
             computed_ = other.computed_.load();
         }
 
         CachedValue& operator=( const CachedValue& other )
         {
             value_ = other.value_;
             computed_ = other.computed_.load();
@@ -74,7 +74,7 @@
         {
             if( !computed_ )
             {
-                absl::MutexLock lock{ &mutex_ };
+                absl::MutexLock lock{ mutex_ };
                 if( !computed_ )
                 {
                     value_ = computer( std::forward< Args >( args )... );
@@ -115,7 +115,7 @@
         {
             archive.ext(
                 *this, Growable< Archive, CachedValue >{
                            { []( Archive& a, CachedValue& value ) {
                                 bool computed;
                                 a.value1b( computed );
                                 value.computed_ = computed;

include/geode/basic/mapping.hpp

@@ -23,8 +23,9 @@
 
 #pragma once
 
-#include <absl/container/flat_hash_map.h>
+#include <absl/algorithm/container.h>
 #include <absl/container/inlined_vector.h>
+#include <absl/container/linked_hash_map.h>
 
 #include <geode/basic/common.hpp>
 
@@ -71,13 +72,13 @@ namespace geode
             return out2in_.at( out );
         }
 
-        [[nodiscard]] const absl::flat_hash_map< T1, Storage< T2 > >&
+        [[nodiscard]] const absl::linked_hash_map< T1, Storage< T2 > >&
             in2out_map() const
         {
             return in2out_;
         }
 
-        [[nodiscard]] const absl::flat_hash_map< T2, Storage< T1 > >&
+        [[nodiscard]] const absl::linked_hash_map< T2, Storage< T1 > >&
             out2in_map() const
         {
             return out2in_;
@@ -100,19 +101,21 @@ namespace geode
             return static_cast< index_t >( out2in_.size() );
         }
 
-        [[nodiscard]] absl::flat_hash_map< T1, Storage< T2 > >& in2out_mapping()
+        [[nodiscard]] absl::linked_hash_map< T1, Storage< T2 > >&
+            in2out_mapping()
         {
             return in2out_;
         }
 
-        [[nodiscard]] absl::flat_hash_map< T2, Storage< T1 > >& out2in_mapping()
+        [[nodiscard]] absl::linked_hash_map< T2, Storage< T1 > >&
+            out2in_mapping()
         {
             return out2in_;
         }
 
     private:
-        absl::flat_hash_map< T1, Storage< T2 > > in2out_;
-        absl::flat_hash_map< T2, Storage< T1 > > out2in_;
+        absl::linked_hash_map< T1, Storage< T2 > > in2out_;
+        absl::linked_hash_map< T2, Storage< T1 > > out2in_;
     };
 
     template < typename T >
@@ -225,6 +228,10 @@ namespace geode
             }
             auto& out_map = this->out2in_mapping().at( out );
             const auto itr2 = absl::c_find( out_map, in );
+            if( itr2 == out_map.end() )
+            {
+                return;
+            }
             out_map.erase( itr2 );
             if( this->out2in( out ).empty() )
             {

include/geode/model/mixin/core/component_type.hpp

@@ -84,6 +84,15 @@ namespace geode
             return type_.get() == other.type_.get() && id_ == other.id_;
         }
 
+        [[nodiscard]] bool operator<( const ComponentID& other ) const
+        {
+            if( type_.get() != other.type_.get() )
+            {
+                return type_.get() < other.type_.get();
+            }
+            return id_ < other.id_;
+        }
+
         [[nodiscard]] std::string string() const
         {
             return absl::StrCat( type_.get(), " ", id_.string() );

include/geode/model/mixin/core/detail/components_storage.hpp

@@ -27,8 +27,8 @@
 #include <fstream>
 #include <memory>
 
-#include <absl/container/btree_map.h>
 #include <absl/container/flat_hash_map.h>
+#include <absl/container/linked_hash_map.h>
 #include <absl/strings/match.h>
 
 #include <bitsery/ext/std_map.h>
@@ -52,7 +52,7 @@
         {
         public:
             using ComponentPtr = std::unique_ptr< Component >;
-            using ComponentsStore = absl::btree_map< uuid, ComponentPtr >;
+            using ComponentsStore = absl::linked_hash_map< uuid, ComponentPtr >;
             using Iterator = typename ComponentsStore::const_iterator;
 
             [[nodiscard]] index_t nb_components() const
@@ -167,7 +167,7 @@
                                 []( Archive& a2, uuid& id,
                                     ComponentPtr& item ) {
                                     a2.object( id );
                                     a2.ext( item, bitsery::ext::StdSmartPtr{} );
                                 } );
                         } } } );
             }

include/geode/model/mixin/core/vertex_identifier.hpp

@@ -57,6 +57,8 @@ namespace geode
 
         [[nodiscard]] bool operator==( const ComponentMeshVertex& other ) const;
 
+        [[nodiscard]] bool operator<( const ComponentMeshVertex& other ) const;
+
         template < typename Archive >
         void serialize( Archive& archive );
 

src/geode/basic/CMakeLists.txt

@@ -109,6 +109,7 @@ add_geode_library(
         "internal/array_impl.hpp"
     PUBLIC_DEPENDENCIES
         absl::flat_hash_map
+        absl::linked_hash_map
         absl::strings
         absl::stacktrace
         absl::symbolize

src/geode/basic/attribute_manager.cpp

@@ -163,7 +163,7 @@ namespace geode
 
         void delete_attribute( std::string_view name )
         {
-            absl::MutexLock lock{ &mutex_ };
+            absl::MutexLock lock{ mutex_ };
             const auto attribute_it = attributes_.find( name );
             if( attribute_it != attributes_.end() )
             {

src/geode/mesh/helpers/convert_surface_mesh.cpp

@@ -23,6 +23,8 @@
 
 #include <geode/mesh/helpers/convert_surface_mesh.hpp>
 
+#include <absl/container/flat_hash_map.h>
+
 #include <geode/basic/attribute_manager.hpp>
 #include <geode/basic/logger.hpp>
 

src/geode/mesh/helpers/detail/split_along_solid_facets.cpp

@@ -139,7 +139,6 @@ namespace geode
             ElementsMapping duplicate_points( const SolidInfo& solid_info )
             {
                 ElementsMapping vertices_mapping;
-                vertices_mapping.reserve( solid_.nb_vertices() );
                 for( const auto vertex_id : Range{ solid_.nb_vertices() } )
                 {
                     vertices_mapping.map( vertex_id, vertex_id );

src/geode/model/mixin/core/vertex_identifier.cpp

@@ -78,6 +78,16 @@
         return component_id == other.component_id && vertex == other.vertex;
     }
 
+    bool ComponentMeshVertex::operator<(
+        const ComponentMeshVertex& other ) const
+    {
+        if( component_id != other.component_id )
+        {
+            return component_id < other.component_id;
+        }
+        return vertex < other.vertex;
+    }
+
     template < typename Archive >
     void ComponentMeshVertex::serialize( Archive& archive )
     {
@@ -398,7 +408,7 @@
                          a.ext( impl.component_vertices_,
                              bitsery::ext::StdSmartPtr{} );
                          a.ext( impl.vertex2unique_vertex_,
                              bitsery::ext::StdMap{
                                  impl.vertex2unique_vertex_.max_size() },
                              []( Archive& a2, uuid& id,
                                  std::shared_ptr< VariableAttribute<
@@ -419,7 +429,7 @@
                             a.ext( impl.component_vertices_,
                                 bitsery::ext::StdSmartPtr{} );
                             a.ext( impl.vertex2unique_vertex_,
                                 bitsery::ext::StdMap{
                                     impl.vertex2unique_vertex_.max_size() },
                                 []( Archive& a2, uuid& id,
                                     std::shared_ptr< VariableAttribute<