Repository navigation
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Priority: ➖ Normal Merge Risk: ⚪ Minimal · up to
|
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments: 1
CHANGELOG.md: 1
5-5: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueAdd PR references to the new changelog entries.
The three new Breaking Changes entries have no inline PR number. Add
(#1195)to each heading, as the other entries do.As per coding guidelines: "Reference PR numbers inline, e.g.
(#374)."Also applies to: 14-14, 18-18
Source: Coding guidelines
ℹ️ Review info
⚙️ Run configuration
- Source mode: Auto
- Repository: GetStream/Vision-Agents
- Branch: feat/stream-py-rust-upgrade
- File: .coderabbit.yaml
- Commit: 497b76c
- Layers: Repository YAML
- Review profile: CHILL
- Plan: Advanced
- Run ID:
29cca2e5-c182-4713-8ae4-acb96d8d3885
⛔ Files ignored due to path filters: 1
uv.lockis excluded by!**/*.lock
📒 Files selected for processing: 21
CHANGELOG.mdagents-core/pyproject.tomlagents-core/vision_agents/core/agents/agents.pyagents-core/vision_agents/core/events/manager.pydev.pyplugins/getstream/PROTOBUF_GENERATION.mdplugins/getstream/_generate_sfu_events.pyplugins/getstream/pyproject.tomlplugins/getstream/tests/test_remote_video_track.pyplugins/getstream/tests/test_sfu_events.pyplugins/getstream/tests/test_stream_edge_transport.pyplugins/getstream/tests/test_track_resolver.pyplugins/getstream/vision_agents/plugins/getstream/_track_resolver.pyplugins/getstream/vision_agents/plugins/getstream/remote_video_track.pyplugins/getstream/vision_agents/plugins/getstream/sfu_events.pyplugins/getstream/vision_agents/plugins/getstream/stream_conversation.pyplugins/getstream/vision_agents/plugins/getstream/stream_edge_transport.pyplugins/inworld/vision_agents/plugins/inworld/rtc_manager.pyplugins/openai/pyproject.tomlplugins/openai/vision_agents/plugins/openai/rtc_manager.pytests/test_agents/test_agents.py
💤 Files with no reviewable changes: 6
- plugins/getstream/PROTOBUF_GENERATION.md
- plugins/getstream/tests/test_sfu_events.py
- plugins/getstream/vision_agents/plugins/getstream/sfu_events.py
- plugins/getstream/tests/test_track_resolver.py
- plugins/getstream/_generate_sfu_events.py
- plugins/getstream/vision_agents/plugins/getstream/_track_resolver.py
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.
Why
stream-py 7.0.0 replaces its aiortc transport with the Rust Video SDK (GetStream/stream-py#303). Vision Agents pinned
getstream>=4.1.0,<5, so it stayed on the old transport. The new SDK changes the RTC surface thatStreamEdgeuses:track_addedgives aRemoteTrackwith decoded I420 frames instead of an aiortc track on the subscriber peer connection. ARemoteTrackhas no id: the SDK keeps one per session and track type, and dropping the last reference unsubscribes it.TrackResolver(which matched WebRTC tracks to SFUTrackPublishedevents) has nothing to do.rtc.TrackPublished,rtc.ParticipantLeft, ...) instead of protobuf messages, so the generatedsfu_eventswrappers and the protobuf conversion inEventManagerget no input.track_addedcan arrive after itsparticipant_left.track_unpublished, and the sameRemoteTrackresumes after unmute.participant_joinedandtrack_addedfor participants already in the call, sorepublish_tracks()after join is not needed.AudioStreamTrackno longer pacesrecv()by default. TheopenaiandinworldRealtime plugins send it on their own aiortc connection, which needs one frame every 20 ms.StreamAPIExceptionis renamed toStreamApiException.The branch also fixes the agent shutdown on call end. The
CallEndedEventhandler startedAgent.close(), and theclose()fromjoin()returned at once because a close was already running.join()then exited while components were still closing, andasyncio.runshut down in the middle of their cleanup. With a Realtime LLM this loggedaclose(): asynchronous generator is already running.User-facing breaks (install only on macOS arm64 and Linux, removed
sfu_events, new participant and track id formats, no video from H.264-only publishers, VP9 publishing,AudioStreamTrackpacing) are inCHANGELOG.md.Changes
getstream[webrtc,telemetry]>=7.0.0invision-agentsandvision-agents-plugins-getstream.StreamEdgemaps the SDK events to the core edge events directly. It keeps eachRemoteTrackuntil its participant leaves, keeps unpublished tracks for unmute, and ignores tracks of sessions that left.RemoteVideoTrack: an aiortcVideoStreamTrackoverRemoteTrack.video_frames()that gives yuv420pav.VideoFrames with RTP timestamps.add_track_subscriber()returns a new one per call.sfu_events.py, its generator and docs,_track_resolver.py, and the protobuf branch inEventManager.open_demo()asks the browser for VP8 (was H.264).openaiandinworldRealtime plugins passpace=TruetoAudioStreamTrack.Agent.close(): a concurrent call waits for the running close. The call-end close runs in its own task, soevents.shutdown()does not wait on the handler that waits for the close.StreamEdgeintegration tests against a real call (join, leave, unpublish and republish, latetrack_added, video frames, two subscribers), unit tests forRemoteVideoTrack, and anAgenttest forjoin()after a call-end close.🤖 Generated with Claude Code