Skip to content

AI-3308: skills and AGENTS.md point at main - #2039

Merged
kanat merged 2 commits into
mainfrom
ai-3308-skills-main
Nov 16, 2026
Merged

kanat merged 2 commits into
mainfrom
ai-3308-skills-main

Conversation

@kanat

@kanat kanat commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

accelerate was merged into main by #2030, so instructions that tell an agent to use it now name main. Docs-only, no code.

File:line Old New
AGENTS.md:5 work happens on accelerate main
.claude/skills/pr/SKILL.md:22 commit subject on accelerate/main main
.claude/skills/add-connector/SKILL.md:84 PR on the accelerate branch main
.claude/skills/parallel-agents/SKILL.md:60,69,88,93 origin/accelerate origin/main
.claude/skills/parallel-agents/SKILL.md:78 check not required on accelerate main (the main rulesets have no required status checks)
.claude/skills/provider_audit/SKILL.md:71 git grep ... origin/accelerate origin/main
.claude/skills/docs/SKILL.md:40 source on accelerate main
.claude/skills/deploy/SKILL.md:104,108 GetStream/chat on branch thierry/accelerate-gke, not master; "same branch" master; "same repo" (thierry/accelerate-gke merged in chat #16465; the staging file is on master)

Found by grepping AGENTS.md, CLAUDE.md, .claude/ and .agents/ for the branch name (not the acceleration/ dir, accelerate-* names or tags):

File:line Old New
.claude/skills/accelerate-sales-engineer/SKILL.md:55 links tree/accelerate, blob/accelerate tree/main, blob/main
.claude/skills/good_morning/SKILL.md:13 Vision-Agents branch accelerate main
.claude/skills/loop_performance_bench/SKILL.md:28 branch off accelerate main
.claude/skills/cli/SKILL.md:35 deployed less often than accelerate moves main

Left on accelerate: sdk-dotnet/SKILL.md:41 — the release workflows still gate on refs/heads/accelerate (release-sdk-dotnet.yml:32, release-sdk-js.yml:19, and publish-sdk-kotlin.yml:66 by branch name); tracked in AI-3309.

Kept: parallel-agents/SKILL.md:8 and provider_audit/vendors.md:4 (history).

Not changed: .claude/skills/sdk-go/SKILL.md:44,103,108-149 and sdks/go/README.md links. The Go release flow copies sdks/go from accelerate onto main; with one branch that flow needs a decision, not a rename.

🤖 Generated with Claude Code

accelerate was merged into main by #2030; instructions that told an agent
to use the accelerate branch now name main (chat master for the deploy values).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@kanat kanat left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VERDICT: NO-GO (1 Should fix).

Checked: 11 of 12 files are true today (accelerate is an ancestor of main; chat master holds the merge of thierry/accelerate-gke, c377a2161f, and the staging and prod values files; the main rulesets have no required status checks). Nothing outside AGENTS.md and .claude/skills changed. The leftover grep over AGENTS.md, .claude/ and .agents/ finds only the sdk-go release flow and history lines. The PR body table matches the diff.

One line is false today, see R1.1.

Comment thread .claude/skills/sdk-dotnet/SKILL.md Outdated
`GetStream.VisionAgents.Models`.

Releases run by hand: Actions, "Release .NET SDK", "Use workflow from" `accelerate`, pick the
Releases run by hand: Actions, "Release .NET SDK", "Use workflow from" `main`, pick the

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Should fix] R1.1 release-sdk-dotnet.yml:32 has if: github.ref == 'refs/heads/accelerate' (and :3, :35 say the run enters the registry-publish environment only from accelerate). That file is unchanged here, so on main today "Use workflow from main" makes the release job skip. The new text sends a human to a run that does nothing. Fix: revert this line to accelerate in this PR and ticket the workflow gate (with release-sdk-js.yml:19, publish-sdk-kotlin.yml:18,23,66, sdk-go.yml:3) together with the sdk-go release flow, or change the gate in the same PR and say so in the body.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in a6c10c8: line reverted; workflow gates tracked in AI-3309.

…moves

release-sdk-dotnet.yml still gates the release on refs/heads/accelerate,
so the skill must keep naming accelerate. Tracked in AI-3309.

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
@kanat
kanat marked this pull request as ready for review November 16, 2026 17:09
@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

Walkthrough

The documentation updates branch references across skills and repository guidance. Most changes replace accelerate or origin/accelerate with main or origin/main. The Sandbox proxy deployment instructions now refer to the master branch of GetStream/chat.

Merge Risk: Low · previous review 40de4

The .NET SDK release instruction now tells maintainers to run the workflow from main, but the workflow only releases from accelerate. Following the instruction would skip the release without publishing anything. Fix that one line, or update the workflow to match, before relying on the documentation. The other branch-reference updates are low risk.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 17a2b91 and 40de428.

Files selected for processing: 12

  • .claude/skills/accelerate-sales-engineer/SKILL.md
  • .claude/skills/add-connector/SKILL.md
  • .claude/skills/cli/SKILL.md
  • .claude/skills/deploy/SKILL.md
  • .claude/skills/docs/SKILL.md
  • .claude/skills/good_morning/SKILL.md
  • .claude/skills/loop_performance_bench/SKILL.md
  • .claude/skills/parallel-agents/SKILL.md
  • .claude/skills/pr/SKILL.md
  • .claude/skills/provider_audit/SKILL.md
  • .claude/skills/sdk-dotnet/SKILL.md
  • AGENTS.md

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 5 remain after this review.

Comment thread .claude/skills/sdk-dotnet/SKILL.md Resolved
@kanat
kanat merged commit 1d49454 into main Nov 16, 2026
6 checks passed
@kanat
kanat deleted the ai-3308-skills-main branch November 16, 2026 17:54
kanat added a commit that referenced this pull request Nov 17, 2026
…when a session is reopened) (#2046)

Ports [#2037](#2037)
(AI-3201) to `main`.

#2037 merged into `accelerate` after `accelerate` was merged into `main`
(#2030). Staging runs `accelerate-v0.6.354`, which was built from
`accelerate`. Without this port, the next staging deploy from `main`
drops #2037.

```
accelerate ──●── #2037 ──► v0.6.354 (staging now)
main       ──●── #2036, #2039, … (15 commits)   ← this PR adds #2037
```

| Check | Result |
| --- | --- |
| `git cherry-pick -x b2334ad` on `origin/main` | clean, no conflicts
|
| `go build ./...`, `go vet` on touched packages | ok |
| `go run ./cmd/openapi` | no diff |
| `npm run types -- --check` (sdks/js) | in step with the spec |
| `go test ./internal/session/ ./internal/conversation/` | ok |
| Migration `20270101090000` | newest on `main` (`20261231090000` before
it); already applied on staging by v0.6.354 |

The code is #2037 unchanged; it was reviewed and merged there.

### Merge with `main` (df06a47)

`main` gained
[#2044](#2044) (session
tools), which touches the same code:

| File | Resolution |
| --- | --- |
| `api/sessions.go` | `declaredTools` now maps `toolOf`, #2044's helper
for one tool |
| `session/records.go`, `records_test.go` | the recorder keeps both
`ToolTimeout` and `Offered` |
| `session/tools.go` | git merged it with no conflict, but `bridge.Run`
unlocked twice and panicked; kept `main`'s single unlock (#2044 holds
the lock over both reads) |
| `sdks/swift/core/generated.json` | regenerated at its pinned generator
commit; `--check` passes |

`go test -race` for session and conversation passes, and so do the
`integration` suites for `internal/api`, `internal/session/...` and
`internal/store`.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

https://claude.ai/code/session_01SWVEMob5wtaNHdUCC1msgG

Co-authored-by: Laurent Schaffner <laurent.schaffner.code@gmail.com>
Co-authored-by: Laurent Schaffner <laurentschaffner@Laurents-MacBook-Pro-Stream.local>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant