Skip to content

Bump android-ci pin so Sonar analyses develop - #82

Merged
gpunto merged 3 commits into
developfrom
ci/bump-android-ci-sonar-on-push
Sep 25, 2026
Merged

gpunto merged 3 commits into
developfrom
ci/bump-android-ci-sonar-on-push

Conversation

@aleksandar-apostolov

@aleksandar-apostolov aleksandar-apostolov commented Sep 21, 2026 •

Copy link
Copy Markdown
Collaborator

Goal

Refs AND-1443

SonarCloud last analysed this repo's develop on 2025-12-23. The Sonar step in the
shared workflow is gated on a pull_request field that is empty on push, so it has
only ever run on PRs and never refreshes the branch baseline. Every PR gate here
measures new code against that frozen baseline.

Implementation

Bump the android-ci.yml pin in .github/workflows/android.yml to pick up
GetStream/stream-build-conventions-android#78. No other pin touched.

Testing

actionlint .github/workflows/android.yml — clean.

Draft until #78 merges. It is currently pinned to that PR's branch commit
(2e7e495). The conventions repo squash-merges and cuts version tags — the previous
pin 8b36d37d is v0.14.0 — so this must be re-pinned to the new release before it
can merge. Expect a large one-off issue count on the first clean develop analysis;
that is the backlog becoming visible, not a regression.

Summary by CodeRabbit

  • Chores
    • Updated the configuration used for automated Android build and verification checks. This is an internal maintenance change; it does not change the app’s features or behavior, or affect the experience available to end users. No user-facing changes are included in this update.

Picks up the Sonar step fix from stream-build-conventions-android#78.
Until it lands, SonarCloud's develop baseline for this repo is frozen and
every PR gate measures new code against it.
@aleksandar-apostolov aleksandar-apostolov added the pr:ci CI changes label Sep 21, 2026
@github-actions

Copy link
Copy Markdown
Contributor

PR checklist ✅

All required conditions are satisfied:

  • Title length is OK (or ignored by label).
  • At least one pr: label exists.
  • Sections ### Goal, ### Implementation, and ### Testing are filled, or the PR is bot-authored.
  • An issue is linked (Linear ticket or GitHub issue), or the PR is bot-authored.

🎉 Great job! This PR is ready for review.

@aleksandar-apostolov
aleksandar-apostolov marked this pull request as ready for review September 21, 2026 12:48
@coderabbitai

coderabbitai Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: 48fefd68-59c7-4a14-be08-6061fe3f3be9

📥 Commits

Reviewing files that changed from the base of the PR and between 5469136 and efc457b.

📒 Files selected for processing (1)
  • .github/workflows/android.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The android-ci job now references revision 68c8917934383ebba59a263c1050531033fd9f75 of the shared Android CI workflow.

Changes

Android CI

Layer / File(s) Summary
Update Android CI workflow revision
.github/workflows/android.yml
The android-ci job now uses revision 68c8917934383ebba59a263c1050531033fd9f75 instead of 8b36d37dd137d47244206d64899c5f8f7c874c3c.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested reviewers: gpunto

Merge Risk: ⚪ Minimal · up to efc45

The updated workflow runs Sonar on pushes to develop and main, refreshing the baseline as intended. No merge-blocking risk remains.

Architecture Summary

Architecture risk: 🔵 Low · up to efc45

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .github/workflows/android.yml: The android-ci job now references workflow revision 68c8917934383ebba59a263c1050531033fd9f75 instead of 8b36d37dd137d47244206d64899c5f8f7c874c3c.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: updating the Android CI pin to enable the Sonar analysis fix.
Description check ✅ Passed The description explains the goal, implementation, testing, related issue, temporary pin status, and expected SonarCloud impact. The required Checklist section is missing, but the description is other…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the workflow pin,
One revision out, one revision in.
The CI path hops along,
Its tag now changed in song.
Then soft paws close the review.

Comment @coderabbitai help to get the list of available commands.

stream-build-conventions-android#78 squash-merged as 68c8917. The previous
pin was that PR's branch commit, which carried an earlier form of the Sonar
condition and sits on a now-deleted branch.
@sonarqubecloud

Copy link
Copy Markdown

@gpunto
gpunto merged commit 61383c6 into develop Sep 25, 2026
14 of 15 checks passed
@gpunto
gpunto deleted the ci/bump-android-ci-sonar-on-push branch September 25, 2026 08:03
@stream-public-bot stream-public-bot added the released Included in a release label Sep 28, 2026
@stream-public-bot

Copy link
Copy Markdown
Collaborator

🚀 Available in v5.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:ci CI changes released Included in a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants