Skip to content

Disable automatic snapshot publishing on develop pushes - #219

Merged
gpunto merged 1 commit into
developfrom
ci/disable-auto-snapshot-publish
Sep 30, 2026
Merged

gpunto merged 1 commit into
developfrom
ci/disable-auto-snapshot-publish

Conversation

@gpunto

@gpunto gpunto commented Sep 30, 2026 •

Copy link
Copy Markdown
Collaborator

Goal

Stop publishing a snapshot on every push to develop. Snapshots can still be published by running the workflow manually.

Closes AND-1581

Implementation

  • Remove the push trigger from publish-snapshot.yml, keeping workflow_dispatch.

Testing

None needed, CI config only.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Snapshot releases now require a manual start and are no longer triggered automatically when changes are pushed to the development branch. Manually started snapshots continue to use the existing release process and configuration; how snapshots are built and published remains unchanged.

@gpunto gpunto added the pr:ci CI changes label Sep 30, 2026
@github-actions

Copy link
Copy Markdown
Contributor

PR checklist ✅

All required conditions are satisfied:

  • Title length is OK (or ignored by label).
  • At least one pr: label exists.
  • Sections ### Goal, ### Implementation, and ### Testing are filled, or the PR is bot-authored.
  • An issue is linked (Linear ticket or GitHub issue), or the PR is bot-authored.

🎉 Great job! This PR is ready for review.

@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

SDK Size Comparison 📏

SDK Before After Difference Status
stream-feeds-android-client 2.55 MB 2.55 MB 0.00 MB 🟢

@gpunto
gpunto marked this pull request as ready for review September 30, 2026 10:48

@aleksandar-apostolov aleksandar-apostolov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coderabbitai

coderabbitai Bot commented Sep 30, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: a3cbfe95-ce74-4616-aa5a-829863f12070

📥 Commits

Reviewing files that changed from the base of the PR and between 852d97c and 0c342d6.

📒 Files selected for processing (1)
  • .github/workflows/publish-snapshot.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The snapshot workflow no longer runs on pushes to develop. It retains the manual workflow_dispatch trigger. The snapshot release job and its configuration are unchanged.

Changes

Snapshot publishing

Layer / File(s) Summary
Restrict snapshot trigger
.github/workflows/publish-snapshot.yml
The workflow no longer runs on pushes to develop. It retains manual dispatch. The snapshot release job and its configuration are unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 0c342

Develop pushes no longer publish snapshots automatically, and manual dispatch still reaches the snapshot publishing path. No material merge risk is established.

Architecture Summary

Architecture risk: 🔵 Low · up to 0c342

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .github/workflows/publish-snapshot.yml: The workflow trigger removes the push event for the develop branch and retains workflow_dispatch; a comment states that snapshots are published manually only.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: disabling automatic snapshot publishing on pushes to develop.
Description check ✅ Passed The description includes the Goal, Implementation, and Testing sections. It clearly explains the workflow change and links the related issue. The optional checklist section is missing, but the descrip…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the release gate,
No push can make the snapshots wait.
A manual tap begins the run,
The job stays set as it was done.
I nibble clover, pleased and bright,
And hop away beneath the moonlight.

Comment @coderabbitai help to get the list of available commands.

@gpunto
gpunto merged commit 2819014 into develop Sep 30, 2026
12 of 13 checks passed
@gpunto
gpunto deleted the ci/disable-auto-snapshot-publish branch September 30, 2026 10:53
@stream-public-bot stream-public-bot added the released Included in a release label Oct 7, 2026
@stream-public-bot

Copy link
Copy Markdown
Collaborator

🚀 Available in v0.11.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:ci CI changes released Included in a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants