Repository navigation
ci: give 7.x Release PRs a title release-please can parse - #322
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On
7.x, release-please titles the Release PRchore: release 7.x. After the merge, it parses that title as a release for version7.xand fails withunable to parse version string: 7.x(run 43258378002). Retitling #319 tochore: release 7.2.0fixed this one release, but every later 7.x Release PR would fail the same way.Solution
Set
group-pull-request-title-patterntochore${scope}: release, so Release PRs on this branch are titledchore(7.x): release. The title no longer contains a version, so release-please takes the version from the PR body, as it already does forchore: release main.How to verify
src/util/pull-request-title.ts). The default pattern doesn't matchchore(7.x): release, so nothing throws. The group pattern matches it withbranch=7.xand no version, sobuildReleasesreads the version from the body.chore(7.x): release, and its merge run reaches "Tag and release".Note
Low Risk
One-line release-please configuration change with no application or runtime impact.
Overview
Adds
group-pull-request-title-pattern": "chore${scope}: release"torelease-please-config.jsonso grouped Release PRs on version branches are titled likechore(7.x): releaseinstead ofchore: release 7.x.That removes the invalid
7.xversion from the title so release-please no longer fails parsing after merge and can take the real semver from the PR body, matching how releases onmainalready work.Reviewed by Cursor Bugbot for commit fd0bd96. Bugbot is set up for automated code reviews on this repo. Configure here.