Mute sync resume no longer races the media replay

[aleksandar-apostolov]

Goal

Fixes AND-1549

Follow-up to #1796.

Implementation

• resumeMuteSync() only re-opens the muteSyncEnabled gate. The listenToMediaChanges()
collectLatest replay is the single path that re-signals tracks after reconnect.
• Removed pendingMuteSyncTracks and its bookkeeping in syncMuteStateToSfu(), cleanup()
  and cancelActiveWork().
• Gate behaviour unchanged: collectors still record local bits while paused and still never
  post to a torn-down SFU.

Net -41 lines. No public API change.

Testing

• ./gradlew :stream-video-android-core:testDebugUnitTest — 1270 passed, 0 failed
• ./gradlew :stream-video-android-core:spotlessCheck :stream-video-android-core:apiCheck
• RtcSessionTest2 gains mute sync resumes without replaying the tracks it skipped —
  verified it fails when the flush is reinstated.
• Device repro from AND-1549 not yet re-run against this branch.

Summary by CodeRabbit

• Bug Fixes
  • Improved mute-state synchronization when media publishing resumes.
  • Camera, microphone, and screen-share states are now re-sent through normal media-change handling, avoiding duplicate or stale synchronization updates.

[github-actions]

PR checklist ✅

All required conditions are satisfied:

• Title length is OK (or ignored by label).
• At least one pr: label exists.
• Sections ### Goal, ### Implementation, and ### Testing are filled, or the PR is bot-authored.
• An issue is linked (Linear ticket or GitHub issue), or the PR is bot-authored.

🎉 Great job! This PR is ready for review.

[github-actions]

SDK Size Comparison 📏

SDK	Before	After	Difference	Status
stream-video-android-core	12.38 MB	12.38 MB	0.00 MB	🟢
stream-video-android-ui-xml	5.68 MB	5.66 MB	-0.02 MB	🚀
stream-video-android-ui-compose	6.19 MB	6.19 MB	0.00 MB	🟢

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: 9736fa9a-b4b2-4e59-9174-bd0b819a44f1

📥 Commits

Reviewing files that changed from the base of the PR and between 49a9d83 and e88fe8a.

📒 Files selected for processing (2)

• stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/call/RtcSession.kt
• stream-video-android-core/src/test/kotlin/io/getstream/video/android/core/rtc/RtcSessionTest2.kt

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.

---

Walkthrough

The change removes deferred mute-sync track storage. resumeMuteSync now only re-enables the sync gate. Media-change collection re-signals tracks after resumption, and tests verify the updated behavior.

Changes

Mute sync lifecycle

Layer / File(s)	Summary
Mute sync gate and replay behavior stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/call/RtcSession.kt	Removed pending-track storage and cleanup. Disabled sync now returns immediately. Resume only re-enables the sync gate.
Resume behavior validation stream-video-android-core/src/test/kotlin/io/getstream/video/android/core/rtc/RtcSessionTest2.kt	Updated tests to verify that resume sends no immediate update and that later audio-track publication sends one update.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: pratimmallick

Merge Risk: ⚪ Minimal · up to e88fe

Mute sync now reopens safely and relies on reconnect media replay to update current track state. The reported tests pass, so the change is mergeable.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 27.27% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 11 functions across 2 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: preventing the mute-sync resume race with media replay.
Description check	✅ Passed	The description includes the goal, implementation details, testing results, regression test coverage, and the remaining device-test limitation. UI, checklist, and reviewer sections are omitted, but th…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{A rabbit saw the mute gate glow
No waiting tracks remained below
The stream resumed with steps kept light
One fresh signal came through right
Ears up, the sync path now runs bright}

_{Comment @coderabbitai help to get the list of available commands.}

[PratimMallick]

LGTM

[sonarqubecloud]

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

[stream-public-bot]

🚀 Available in v1.36.0