Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feat/flu-852-call-host #1441 +/- ##
==========================================================
+ Coverage 44.58% 44.69% +0.10%
==========================================================
Files 423 423
Lines 31495 31505 +10
==========================================================
+ Hits 14041 14080 +39
+ Misses 17454 17425 -29 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
renefloor
added this pull request to stack #1442
October 9, 2026 06:12
StreamVideo(...) builds through StreamVideo.create and is the only path that sets up logging. Start-up is one awaitable ready future. A client built inside StreamVideo.runWithoutMedia, as the background push handler now does, applies no audio configuration and never creates the media device notifier. Replacing the singleton disposes the old client, the deprecated androidAudioConfiguration and precacheGenericSdps are removed, and the client state keeps only the two options it reads. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
renefloor
force-pushed
the
feat/flu-854-stream-video-constructor
branch
from
October 9, 2026 12:27
3710761 to
2d5d505
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes FLU-854
Part of FLU-859 · 26/26, stacked on #1440
What changed
One builder.
StreamVideo(...)builds throughStreamVideo.createand then installs the singleton, so the forwarding is written once.StreamVideo.forTesting(C2) keeps its seams.Start-up is one awaitable
readyfuture. The constructor used to start four things with no handle on them.readynow covers:It completes once they have run, and never with an error; failures are logged as before.
Logging only from the singleton path.
_setupLoggerused to run in every constructor and changed the process-wideStreamLog()for every instance, test ones included. NowStreamVideo(...)applieslogPriorityandlogHandlerFunction. A client fromcreatedoesn't;StreamVideo.configureLoggingis the explicit call for it.failIfSingletonExists: falsedisposes the client it replaces (InstanceHolder), instead of only disconnecting it.A client for background push handling sets up no media.
StreamVideo.runWithoutMedia(body)runsbodyin a zone. A client built inside it,setsUpMedia == false:RtcMediaDeviceNotifier;StreamVideoPushHandler.handleBackgroundMessagebuilds its client through it. The zone carries through the app's asynccreateStreamVideo, so the app changes nothing.CallHostgainssetsUpMedia.Builders moved out of the constructor:
NetworkMonitorSettings.build()makes theInternetConnection, andClientEventReporter.createthe reporter or the no-op one.Options:
androidAudioConfigurationis removed.precacheGenericSdpsparameter is removed.MutableClientStateno longer holds a second reference to the options; it takes the two values it reads,allowMultipleActiveCallsandmultiCallAudioPolicy.Decisions to check
createStreamVideorelies on every app remembering it, and the media setup happens anyway when one forgets. The zone needs no app change, because the handler already owns the call tocreateStreamVideo.runWithoutMediais public, so an app with its own background handler can use it too.tokenLoader,onTokenUpdatedandpushNotificationManagerProviderstay constructor parameters. They belong to the user and the app wiring, not to tunable behaviour, and moving them intoStreamVideoOptionswould make the options per-user.readywaits for the auto-connect. An app that awaits it before showing the call list gets a connected client, or a logged failure. WithoutautoConnect, it waits only for the audio configuration and the environment.Tests
stream_video_without_media_test(3), on Android with a mockRtcMediaDeviceNotifier.instance:stream_video_constructor_test(4):readycompletes after the auto-connect, also when it fails;background_push_handler_test: the factory runs without media, also after anawait, and the zone ends with it.MockCallHostanswerssetsUpMediawithtrue.stream_video: 1316 passed;stream_video_push_notification: 68;stream_video_flutterwithout goldens: 729.liband dogfooding analyze without errors.🤖 Generated with Claude Code