Repository navigation
feat(android): bind the BB conversation target to its configured provider, codex or claude-code - #1046
Open
egerev wants to merge 3 commits into
Open
feat(android): bind the BB conversation target to its configured provider, codex or claude-code#1046egerev wants to merge 3 commits into
egerev wants to merge 3 commits into
Conversation
…ider, codex or claude-code The Android BB conversation target accepted only a thread that reports provider codex. Its private admin config now takes an optional provider, codex by default or claude-code; any other value refuses the configuration. The metadata check compares the thread's providerId with that setting, so a target configured for one provider never binds a thread of the other. Every other check stays: thread, project, environment, host, workspace, CLI hash, principal, device and control. A caller cannot choose the provider, and the native engines, default engine and model pins are unchanged. Spec: ANYM-993 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: egerev <egor@gosync.ai>
egerev
enabled auto-merge
November 18, 2026 11:54
… Codex request After the switch the unknown Codex request is refused under its original ID with either text, its receipt file stays byte-identical, and rollback reads it back still unknown; one send in total. Spec: ANYM-993 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: egerev <egor@gosync.ai>
…he BB conversation guide The opening and the end-to-end check now name the configured existing conversation of the selected provider (Codex by default, Claude Code when configured). The first activation and its undo are kept apart from a provider switch, whose undo restores thread_id and provider together in the existing object. Spec: ANYM-993 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: egerev <egor@gosync.ai>
egerev
disabled auto-merge
November 18, 2026 12:04
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem (DK-6): owner, relayed 2026-11-18 (translated): "let's try running a Claude Code session there as a replacement for Codex for executing tasks, and for now temporarily route Grok there through Claude Code". The Android
android_taskBB conversation target accepted only a thread reportingproviderId == 'codex', so a configured Claude Code thread could never bind.Expected:
bb_conversation.providerin the private admin config:codex(the default when absent) orclaude-code. The metadata check compares the thread'sproviderIdwith that setting, so neither provider is ever accepted indiscriminately. Null, other spellings and other providers refuse the configuration. A caller cannot choose the provider. Every other check stays: thread, project, environment, host, workspace, CLI hash, principal, device andandroid:control. Native engines,default_engineand model pins are unchanged; there is no new engine, queue or executor.Change:
config.py: one optionalLiteral['codex', 'claude-code']field.bb_conversation.py: one comparison.docs/android-bb-conversation.md: the config example, plus the default, the explicit Claude Code switch and rollback.Proof: new
services/android/tests/test_bb_conversation_provider.py(29 cases,# spec: ANYM-993) runs the real HTTP app and strict config with a synthetic BB CLI. No phone, ADB, model or real BB call.providerkey, so a Claude Code target can't be configured and every claude-code-configured guard case fails with it. The 2 that pass are today's behaviour: the default Codex target, and the default refusing a Claude Code thread.thread tell;providerrefused, with discovery staying BB-free;Not claimed: installing the package, swapping the paired config on the phone host (only with no work in either thread, with the UTC switch and rollback recorded), Grok routing, and any real model, phone or order run. All of that is root-owned runtime acceptance after green main, and there's no agent-feature live comparison from source checks. Tiden: the provider rule is the new story ANYM-1003 on the intent branch below, under ANYM-967. ANYM-993's main text is unchanged, because its BB-conversation text is pending on the open
intent/2026-11-17-anym-993-android-observation-is. The tests keep the ANYM-993 marker that the existing BB-conversation tests use, because the PR check resolves only main andproposal//review/branches.Tiden intent branch: intent/2026-11-18-the-android-bb-conversation
Spec: ANYM-993
Change path: AUTO (owner-requested provider choice in an optional admin config; no grants, authentication or reserved-decision change; signal words are synthetic test principals' existing permission lists)
Review record: none (owner 11-11: no reviews)
🤖 Generated with Claude Code