Repository navigation
test(android): order the exhausted-budget read and wait for the held connector's completion; diagnose both (CI 44355808074, 44354309423) - #1071
Merged
Conversation
…d task read (CI 44355808074, 44354309423) Two new diagnostic files, real lifecycle with the synthetic native/ADB fakes: - A tick gate orders the budget read against the .3 s timer wake: exhausted first, the wake is refused lease_unavailable; read late, the wake was admitted, the obligation received and the budget pruned (KeyError). - A barrier right after the 'held' forward commit shows the row visible to another thread while the connector task is still pending, and the task done right after that loop step: no await window in the connector. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: egerev <egor@gosync.ai>
…for the held connector's completion - test_exhausted_active_budget_refuses_due_input_before_any_native_preflight: a scoped Supervision.tick gate opens only after the budget is exhausted, so a runner slower than the .3 s timer cannot admit the wake first (CI run 44355808074). Delay, caps and native-preflight assertions are unchanged. - test_an_ended_request_handle_never_reacquires_while_the_new_request_awaits_admission: the 'held' commit precedes the connector task's completion in the same loop step, so the test still requires completion but waits for it within until()'s bound (CI run 44354309423). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: egerev <egor@gosync.ai>
egerev
added a commit
that referenced
this pull request
Nov 18, 2026
…ransliteration Root granted this exact accepted main SHA (main CI 44368410370, publication 1616, exact sync B 44369454136) after the earlier merge-group failure (run 44355808074, android test_order_supervision). The PR's own scope is unchanged: packages/npm/test/base-url-boundaries.test.js and tests/test_people_transliteration_contract.py only. Signed-off-by: egerev <egor@gosync.ai> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two Android CI failures are test observations, not product defects. Both mechanisms are reproduced below. Which interleaving the CI runs actually hit is UNKNOWN: neither run kept the state at the moment of failure. Both tested Android trees (38f5b79 for #1065's queue run, 8a4e0af for #1066's head) are identical to main 02ff2f5. Production code is unchanged.
A. CI run 44355808074:
test_exhausted_active_budget_refuses_due_input_before_any_native_preflightraisedKeyErrorat line 566.end()first retains the handle and budget, and only then makes the terminal state visible. The fake native child's timer is due 0.3 s after its check; locally about 0.21 s of that remains whenfinished()returns.received. The next tick drops the handle (no refs) and, in the same tick, prunes the budget, which is the intended contract.Supervision.tickgate. It is installed with monkeypatch beforehost(), so it is restored at teardown. It opens only afterseconds_used = seconds_limit, in afinally. The 0.3 s delay, the caps and every native-preflight assertion are unchanged.B. CI run 44354309423:
test_an_ended_request_handle_never_reacquires_while_the_new_request_awaits_admissionfailed at line 68 (connector task pending).ForwardJournal.close()commits theheldrow. Everything after that commit, up to the connector task's completion, is synchronous, so it happens in the same loop step.ended.task == firstand still require the task to complete, waiting for it with the existinguntil()and its 5 s bound. No other assertion, rig or timeout changes.New diagnostic files (real lifecycle, synthetic native/ADB fakes, in-memory barriers):
test_budget_supervision_diagnostics.pygates the tick.lease_unavailable, there are 0 native inputs and 1 turn.received, the wake isaccepted, 2 turns. This is line 566'sKeyError.test_usb_settlement_diagnostics.pyholds the loop thread right after theheldcommit.collection_cleanup_unconfirmed. The task is not done.Red/green on disk: the same private perturbations were used for both runs. The test thread reads 0.6 s after
finished(), and the loop thread pauses 0.3 s after theheldcommit.KeyError, and line 68's... and False.The fixed budget test still catches a missing refusal. These are in-memory mutants:
budget(): killed, with 117 wakes reaching native preflight.authority()skippingbudget(): killed, with 121 admissions.Local runs: the touched USB and budget files pass (71/71), and so does the full Android suite (1063 passed, 1 skipped; the 4
test_screen_quality.pyfailures are this host lacking Tesseractind, which the CI step installs andDEEDKIT_OCR_REQUIRED=1demands). Ruff is clean.Spec: ANYM-993, ANYM-997
Change path: AUTO (test-only ordering of two observations; no cap, deadline or contract change)
Review record: none (owner 11-11: no reviews)
🤖 Generated with Claude Code