-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Make all windows float above other apps #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| // FloatingWindowModifier.swift — Insomnia GUI | ||
| // | ||
| // A SwiftUI ViewModifier that makes a window float above all other windows. | ||
| // Uses NSViewRepresentable to find the specific hosting NSWindow rather than | ||
| // iterating all app windows. Important for LSUIElement menu bar apps where | ||
| // windows should stay visible even when the user clicks on other applications. | ||
|
|
||
| import AppKit | ||
| import SwiftUI | ||
|
|
||
| /// Makes the hosting NSWindow float above all other windows. | ||
| /// | ||
| /// Finds the NSWindow backing the SwiftUI view and sets its | ||
| /// level to `.floating`. This keeps Insomnia's windows visible even when | ||
| /// focus moves to another app — important for a menu bar utility. | ||
| struct FloatingWindow: ViewModifier { | ||
| /// Applies the floating window level to the view's hosting window. | ||
| func body(content: Content) -> some View { | ||
| content | ||
| .background(FloatingWindowAccessor()) | ||
| } | ||
| } | ||
|
|
||
| /// Resolves the specific NSWindow hosting the modified SwiftUI view. | ||
| /// | ||
| /// Uses `NSViewRepresentable` to access the underlying `NSView`, then | ||
| /// reads its `.window` property to set the level. This avoids iterating | ||
| /// all app windows and eliminates timing-based delays. | ||
| private struct FloatingWindowAccessor: NSViewRepresentable { | ||
| /// Creates the backing NSView and sets its window to floating level. | ||
| func makeNSView(context: Context) -> NSView { | ||
| let view = NSView() | ||
| // Set floating level once the view is attached to a window | ||
| DispatchQueue.main.async { | ||
| view.window?.level = .floating | ||
| } | ||
| return view | ||
| } | ||
|
|
||
| /// Re-applies floating level when the view updates (e.g., window reappears). | ||
| func updateNSView(_ nsView: NSView, context: Context) { | ||
| DispatchQueue.main.async { | ||
| nsView.window?.level = .floating | ||
| } | ||
| } | ||
| } | ||
|
|
||
| /// Convenience extension for applying the floating window modifier. | ||
| extension View { | ||
| /// Makes the hosting window float above all other windows. | ||
| func floatingWindow() -> some View { | ||
| modifier(FloatingWindow()) | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.