Repository navigation
Verify bounces before acting on them; refresh the dashboard GIF - #27
Merged
Merged
Conversation
Any message that looked like a bounce (a mailer-daemon sender, an "Undeliverable" subject) counted toward the bounce rate even when it matched nothing Franco sent, so a few spoofed messages could trip the kill switch, and delay notices were treated as hard failures. - parse_bounce(): recipients from RFC 3464 Final-/Original-Recipient (or the addresses in the text) and permanence from Status 5.x.x vs 4.x.x or delay wording; referenced_ids(): In-Reply-To and References. - Handler acts only on a report that matches a sent outbox row (by Message-ID, or an address emailed in the last 14 days), names that row's recipient, is permanent, and hasn't been counted; otherwise it logs bounce_ignored and changes nothing. The SMTP adapter now passes References/Content-Type/Auto-Submitted headers. - tests/test_bounces.py: real Gmail and RFC 3464 reports, References and recent-send matching, spoofed reports, wrong recipient, old sends, delays, double counting. - scripts/record_demo.py seeds researched accounts (campaign, owner, score, sourced observation), M1/F1 campaigns in preview and the compliance footer; docs/dashboard.gif re-recorded.
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Comment on lines
+13
to
+15
| from tests.test_outbox_native import ( # noqa: F401 (state is a fixture) | ||
| FakeProvider, make_handler, seed_prospect, state, | ||
| ) |
Security review follow-up: anyone who knows whom Franco emails could forge a report naming that address. Only a Message-ID match (In-Reply-To or References pointing at an email Franco sent, which only its recipient has) is acted on automatically; an address-only match is logged as bounce_needs_review and changes nothing (no invalid mark, no bounce count, no kill switch).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any message that looked like a bounce (a mailer-daemon sender, an
"Undeliverable" subject) counted toward the bounce rate even when it
matched nothing Franco sent, so a few spoofed messages could trip the kill
switch, and delay notices were treated as hard failures.
the addresses in the text) and permanence from Status 5.x.x vs 4.x.x or
delay wording; referenced_ids(): In-Reply-To and References.
Message-ID, or an address emailed in the last 14 days), names that row's
recipient, is permanent, and hasn't been counted; otherwise it logs
bounce_ignored and changes nothing. The SMTP adapter now passes
References/Content-Type/Auto-Submitted headers.
recent-send matching, spoofed reports, wrong recipient, old sends,
delays, double counting.
score, sourced observation), M1/F1 campaigns in preview and the
compliance footer; docs/dashboard.gif re-recorded.