Skip to content

Make ClickableText focusable and clickable for accessibility#73

Open
PatrykMis wants to merge 1 commit into
GrapheneOS:mainfrom
PatrykMis:a11y-and-bumps
Open

Make ClickableText focusable and clickable for accessibility#73
PatrykMis wants to merge 1 commit into
GrapheneOS:mainfrom
PatrykMis:a11y-and-bumps

Conversation

@PatrykMis
Copy link
Copy Markdown
Contributor

This change adds a no-op .clickable {} modifier to our custom ClickableText implementation.
Previously, the component relied solely on pointerInput for tap handling, which does not expose a clickable action in the Compose semantics tree. As a result, screen readers like TalkBack often failed to recognize these elements, leading to:

  • Missing or incomplete announcements (e.g., reading only the bullet, not the text).
  • Unstable focus navigation when moving through lists/items.

By adding .clickable {} — even with an empty click handler — we ensure that:

  • Screen readers see the element as a proper focusable target with a click action.
  • All list items and changelog entries are consistently read aloud.
  • Focus no longer “jumps” or gets stuck on decorative bullets.

No changes to visual appearance or business logic; purely an accessibility fix + dependency updates.

Comment thread app/src/main/kotlin/app/grapheneos/info/ui/reusablecomposables/ClickableText.kt Outdated
@PatrykMis PatrykMis force-pushed the a11y-and-bumps branch 3 times, most recently from 4467559 to 7dcd698 Compare August 17, 2025 09:08
Copy link
Copy Markdown
Member

@soupslurpr soupslurpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing this issue and working around it, improving accessibility.

@RankoR
Copy link
Copy Markdown

RankoR commented May 21, 2026

@PatrykMis could you please:

  • Remove changes to the gradle-related files
  • Rebase on the current main

Signed-off-by: Patryk Miś <foss@patrykmis.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants