Fix cell-based location accuracy and geocoder robustness#35
Open
thomasbuilds wants to merge 4 commits into
Open
Fix cell-based location accuracy and geocoder robustness#35thomasbuilds wants to merge 4 commits into
thomasbuilds wants to merge 4 commits into
Conversation
The Wi-Fi path divides the 6-sigma estimate by 6 to report the 1-sigma accuracy Location expects, but the cell path reported the raw 6-sigma value, making cell-based fixes report a radius 6 times too large.
An empty or single-element coordinates array would throw IndexOutOfBoundsException, which isn't an IOException and so escapes the handler in GeocodeProviderImpl, leaving the request's callback uncompleted.
Each range() call created a new single-thread executor that was only reclaimed by finalization.
mio-19
added a commit
to mio-19/repo
that referenced
this pull request
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
report cell-based location accuracy as 1-sigma: the Wi-Fi path divides the 6-sigma estimate by 6 to report the 1-sigma accuracy Location expects, but the cell path reported the raw 6-sigma value, so cell-based fixes reported a radius 6 times too large.
skip geocoder features with fewer than two coordinates: an empty or single-element coordinates array threw IndexOutOfBoundsException, which is not an IOException and escaped the handler in GeocodeProviderImpl, leaving the request callback uncompleted.
reuse a single executor in WifiApRanger: each range() call created a new single-thread executor that was only reclaimed by finalization.
fix forward geocode parameter logging: lowerLeftLatitude logged the longitude value and the upperRightLongitude label was miscased.