Repository navigation
Conversation
Recompile with each erroring node hidden until the graph compiles, keep a failed executor update from leaving a dangling output, and avoid rendering a stale graph after a compile fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI disclosure: this PR was written by an AI agent (Claude Code), including the code, the tests, and this description. Before opening it, I asked on Discord whether AI-generated PRs were okay and was told they were. It's a draft until I've finished testing it by hand in the editor.
When a node has a type error, the runtime now recompiles with that node hidden, as if its eye icon were off, so the rest of the document keeps rendering instead of the whole viewport failing. A hidden node passes its primary input through, which can break the next node downstream, so this repeats until the graph compiles. Hiding a layer ends the chain, as the issue describes. The hiding only happens in the network the runtime compiles. The document isn't changed, and each node that got hidden still shows its error in the graph.
NodeNetwork::hide_nodehides the node at an error's path. When the path goes through a definition other instances share, it hides the node in a copy belonging to that one instance, so the other instances keep it.DynamicExecutor::updateno longer movesoutputto the new network until it's in the tree. Before, a failed update left it pointing at a node that didn't exist.eval_graph_oncein the test utils now fails on type errors directly, since a broken graph can render now.Limitations: type checking still stops at the first error, so a chain of N broken nodes takes N recompiles. Hidden nodes only show their error bubble, with no separate "hidden" look.
Closes #1553