Skip to content

Hide nodes with type errors so the rest of the graph still renders - #4968

Closed
TTyChud wants to merge 1 commit into
GraphiteEditor:masterfrom
TTyChud:bypass-erroring-nodes
Closed

TTyChud wants to merge 1 commit into
GraphiteEditor:masterfrom
TTyChud:bypass-erroring-nodes

Conversation

@TTyChud

@TTyChud TTyChud commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

AI disclosure: this PR was written by an AI agent (Claude Code), including the code, the tests, and this description. Before opening it, I asked on Discord whether AI-generated PRs were okay and was told they were. It's a draft until I've finished testing it by hand in the editor.

When a node has a type error, the runtime now recompiles with that node hidden, as if its eye icon were off, so the rest of the document keeps rendering instead of the whole viewport failing. A hidden node passes its primary input through, which can break the next node downstream, so this repeats until the graph compiles. Hiding a layer ends the chain, as the issue describes. The hiding only happens in the network the runtime compiles. The document isn't changed, and each node that got hidden still shows its error in the graph.

  • NodeNetwork::hide_node hides the node at an error's path. When the path goes through a definition other instances share, it hides the node in a copy belonging to that one instance, so the other instances keep it.
  • DynamicExecutor::update no longer moves output to the new network until it's in the tree. Before, a failed update left it pointing at a node that didn't exist.
  • Now that the executor keeps the last network that compiled, the runtime refuses to render it while the latest compile has failed (for an error on something that can't be hidden, like the renderer's own nodes). This stops old artwork from replacing the "cannot render" overlay when you pan.
  • The node graph shows evaluation errors alongside type errors, since the graph still evaluates around the hidden nodes.
  • eval_graph_once in the test utils now fails on type errors directly, since a broken graph can render now.

Limitations: type checking still stops at the first error, so a chain of N broken nodes takes N recompiles. Hidden nodes only show their error bubble, with no separate "hidden" look.

Closes #1553

Recompile with each erroring node hidden until the graph compiles, keep a failed executor update from leaving a dangling output, and avoid rendering a stale graph after a compile fails.
@TTyChud TTyChud closed this Nov 17, 2026
@TTyChud
TTyChud deleted the bypass-erroring-nodes branch November 17, 2026 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hide any nodes that are erroring so the remaining graph still renders

1 participant