Skip to content

Fix false positives in the migration API check and scaffolder - #4974

Merged
Keavon merged 1 commit into
masterfrom
migration-check-fixes
Nov 18, 2026
Merged

Keavon merged 1 commit into
masterfrom
migration-check-fixes

Conversation

@Keavon

@Keavon Keavon commented Nov 18, 2026

Copy link
Copy Markdown
Member

No description provided.

@github-actions

Copy link
Copy Markdown

This PR's title is accepted as an admin set it. The review would otherwise have noted:

  • It's too vague to tell what the change does.

Suggested titles:

Fix the migration API check and scaffolder flagging '#[data]' fields and compiled migrations as missing migrations
Fix the migration scaffolder ignoring compiled migrations, and the API check flagging changes to '#[data]' fields

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@Keavon
Keavon added this pull request to the merge queue Nov 18, 2026
Merged via the queue into master with commit 455008d Nov 18, 2026
15 checks passed
@Keavon
Keavon deleted the migration-check-fixes branch November 18, 2026 04:20

This branch was successfully deployed

1 active deployment
graphite-dev (Preview) — 045a5641 Deployed Nov 18, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant