Repository navigation
refactor: the DLQ has one retry policy, the only one that ever applied - #441
Conversation
Since #428 only consumers of execution events save to the DLQ, so every row got AGGRESSIVE_RETRY. The pod, result and default policies, the strategy enum, retry_policy_for and the event type groupings only it read go; the policy keeps the same values: 5 tries, 30 s doubling up to 300 s, 10% jitter.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes
🚀 New features to boost your workflow:
|



Summary
The DLQ picked one of four retry policies by event type (models.py). Since #428 only the scheduler and the notification consumer save to the DLQ, and both read execution events, so every row got
AGGRESSIVE_RETRYand the other three never ran. The DLQ docs still listed all four.Changes
One
RETRY_POLICYwith the values that applied: 5 tries, 30 s doubling up to 300 s, 10% jitter. The pod, result and default policies,RetryStrategy,retry_policy_forand the immediate-retry branch go, plus theEXECUTION_TYPES,POD_TYPES,SECURITY_TYPESandUSER_TYPESsets that only the lookup read. Retry timing for every real DLQ row stays the same.Type of Change
Test Plan
cd backend && uv run pytest tests/unit)cd frontend && npm run test)docker compose exec -T backend sh -c 'uv sync --group test --no-dev --frozen --no-install-project --no-build && pytest tests/e2e')cd frontend && npm run test:e2e)./deploy.sh openapi, then./deploy.sh types), never edited by handValidation: 541 unit tests pass, including a new check of the delay curve; the discard test now reads the limit from the policy. Ruff, mypy strict, the orphan check and strict mkdocs pass.
Checklist
pre-commit run --all-filesand all checks passSummary by cubic
The DLQ picked one of four retry policies by event type, but since the scheduler and notification consumer are the only ones that save to the DLQ and both read execution events, every row got the aggressive policy and the other three never ran. Replaces them with one
RETRY_POLICYthat keeps the values that actually applied: 5 tries, 30 s doubling up to 300 s, 10% jitter.RetryStrategy,retry_policy_for, the immediate-retry branch, and the event type sets only the lookup read.Written for commit dc6f52a. Summary will update on new commits.