Repository navigation
Document local Rust checks - #56
Merged
Merged
Conversation
Co-Authored-By: GPT-5 Codex <noreply@openai.com> Dispatch-Task: symphony-claude-md-cargo-test-note
Co-Authored-By: GPT-5 Codex <noreply@openai.com> Dispatch-Task: symphony-claude-md-cargo-test-note
Co-Authored-By: GPT-5 Codex <noreply@openai.com> Dispatch-Task: symphony-claude-md-cargo-test-note
Co-Authored-By: GPT-5 Codex <noreply@openai.com> Dispatch-Task: symphony-claude-md-cargo-test-note
There was a problem hiding this comment.
Code Review
This pull request updates CLAUDE.md with detailed instructions on Rust toolchain setup, local testing, and linting guidelines. The review feedback points out two issues in the documentation: a command error where running rustup toolchain install without arguments fails (suggesting rustup show instead), and a factual inaccuracy regarding how macOS handles Linux-specific compilation branches.
Co-Authored-By: GPT-5 Codex <noreply@openai.com> Dispatch-Task: symphony-claude-md-cargo-test-note
Co-Authored-By: GPT-5 Codex <noreply@openai.com> Dispatch-Task: symphony-claude-md-cargo-test-note
kriszyp
marked this pull request as ready for review
October 15, 2026 04:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
CLAUDE.mdTesting to requirecargo test,cargo clippy --all-targets, andcargo fmt --checkbefore pushing Rust changes, and point Conventions at the all-target Clippy command. Testing also records the pinned toolchain and PATH requirements, the addon rebuild before Node tests, and the Linux checks required before macOS pushes.For the human reviewer
npm testdoes not run the Rust checks CI enforces. I kept the checks inCLAUDE.mdinstead of adding a package script or pre-push hook, which would exceed the requested documentation-only scope. That choice is easy to revise, but it relies on contributors following the instructions; CI still catches misses.cargo fmt --checkworks on either platform. This adds a Linux environment step but catches platform-specific failures before PR CI.rustup toolchain installwithout a toolchain argument: rustup 1.29.1 accepts that form and installs the active toolchain, which this repo defines inrust-toolchain.toml. The Rustup 1.28.0 release notes document the no-argument behavior;rustup showreports the active toolchain but does not install it.Verification
cargo --versionreported1.94.1.cargo test: 144 passed, 0 failed.cargo clippy --all-targets: passed.cargo fmt --check: passed.git diff --check: passed.npm run build:debugandnpm testwere not run because this change is documentation-only; no source or generated addon code changed.Complexity: easy
🤖 Generated with OpenAI Codex
Review-Coverage: authored=codex; ran=gemini,claude; adjudicated=domain; declined=cursor-grok,cursor-kimi,cursor-muse,cursor-composer; rounds=6; full=1 @ bd48172
Human-Review-Need: 3 (decisions: local-linux-before-push, contributor-guidance-layer) @ bd48172