Repository navigation
Release v0.55.4: own servers only for restricted members, all roles on the Roles page, base URL secrets - #1781
Merged
Merged
Conversation
Access is the union of all role assignments, but the roles pages showed and edited only the deprecated single users.mcpRoleId, so a role granted by a single sign-on group stayed invisible. Add GET /api/roles/members with all assignments and the connectors they reach, edit manual roles through PUT /api/roles/assignments/:userId, mark synced and all-workspace roles read-only, and return mcpRoles from GET /api/users.
A hand-made REST connector whose base URL carries its credential in the
path (a Bitrix24 inbound webhook, /rest/<user>/<code>/) kept the code in
plaintext in connectors.base_url and returned it to admins and the
owner. The secret-literal extraction on save did not know these shapes.
- Detector: vendor-anchored rules for Bitrix24 (cloud and self-hosted),
Slack, Discord, Microsoft Teams, Zapier and Make webhook URLs, and the
password in scheme://user:password@ for every HTTP connector type.
Power Automate sig=, Google Chat key/token and Telegram were already
covered by the query and token rules.
- Save: only the secret segment moves into a variable named so that
isSecretName masks it; calls interpolate {{VAR}} verbatim, so the URL
sent is unchanged.
- Start-up pass repairBaseUrlSecrets, run after the database pass: same
rules minus the long-random-token heuristic, compare-and-swap on
base URL and updatedAt, strict decryption of the variables, one
summary log line with ids and counts only.
- API output masks a secret still in an HTTP base URL (and the catalog
baseline) as ********; a form that sends the masked URL back keeps
the stored one, a URL edited around the mask is refused.
In a restricted workspace a member who is not an admin used to see every MCP server holding a connector they could see, with its name, owner, connectors, endpoint and usage. They now see only the servers they own, on every route that lists, reads, counts or reports servers: the servers API (reads and writes answer the unknown-id 404), the server picker and consent page, connections, API keys, connector detail, the audit log, tool performance and breakdowns, and the server links on the shared MCP endpoint. A restricted member with only their own server is granted the workspace connection, where their roles decide the tools. File Search detail routes answer 404 unless the member owns the connector, also for one shared through their roles. The catalog's installed flags count only connectors the member can see, and testing values for an existing connector is limited to its owner or an admin.
member-visibility.routes.ts records, for each controller handler, what a member who is not an admin gets in a restricted workspace. A spec reads every controller through Nest route metadata and fails on a route without a decision or a decision without a route, and checks admin-only and scoped decisions against the code. MemberVisibilityInterceptor enforces the admin-when-restricted decisions (knowledge graph and skills reads, learning projects, plan fit) without changing those controllers. An integration spec runs the restricted VIEWER scenario against PostgreSQL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release v0.55.4: one PR so main needs a single CI round. It folds three reviewed PRs and the version bump.
What changes
Member visibility (Restricted mode), from #1779
POST /api/adapters/:slug/verifywithconnectorIdneeds the connector's owner or an admin, in both modes.member-visibility.routes.tsrecords a visibility decision for every API route;member-visibility.routes.spec.tsfails when a route has none. A PostgreSQL scenario spec covers a restricted Viewer end to end.Roles page shows every role, from #1777
PUT /api/roles/assignments/:userId). New admin endpointGET /api/roles/members.Secrets typed into HTTP base URLs, from #1778
user:password@move into encrypted variables on save, and in one pass at start-up. The base URL keeps the host and shows{{VAR}}where the secret was; calls resolve to the original URL.After upgrading
No database migration. Cloud and self-hosted behave the same.
Checks on this branch
npx tsc --noEmit: clean.npm run lint:check: 0 errors, 11 warnings already on main.npx tsc --noEmit: clean.npx jest src/settings src/roles src/mcp-servers src/usersplus the base-URL secret specs: 31 suites passed, 3 skipped (env-gated), 2,130 tests passed.generate-llms-txt,generate-cli-operationsregenerated;adapter-count --checkOK.RolesController.listMembersroute (admin).Closes #1777, closes #1778, closes #1779.