Skip to content

Release v0.55.4: own servers only for restricted members, all roles on the Roles page, base URL secrets - #1781

Merged
helpcodeai merged 6 commits into
mainfrom
release/v0.55.4
Nov 17, 2026
Merged

helpcodeai merged 6 commits into
mainfrom
release/v0.55.4

Conversation

@helpcodeai

Copy link
Copy Markdown
Contributor

Release v0.55.4: one PR so main needs a single CI round. It folds three reviewed PRs and the version bump.

What changes

Member visibility (Restricted mode), from #1779

  • A member who is not an admin sees only the MCP servers they own, on every route: servers API, picker and consent page, connections, API keys, audit and tool performance, and the server links of the shared endpoint. Other ids answer 404 like unknown ids.
  • File Search detail routes answer only the connector's owner (and admins).
  • Knowledge graph, skills, learning projects and plan fit are admin-only when the workspace is restricted.
  • POST /api/adapters/:slug/verify with connectorId needs the connector's owner or an admin, in both modes.
  • member-visibility.routes.ts records a visibility decision for every API route; member-visibility.routes.spec.ts fails when a route has none. A PostgreSQL scenario spec covers a restricted Viewer end to end.

Roles page shows every role, from #1777

  • Settings → Roles and Users list every MCP role of each member with its source (manual, single sign-on group, all workspaces) and the connectors those roles reach. Manual roles are edited with a multi-select (PUT /api/roles/assignments/:userId). New admin endpoint GET /api/roles/members.

Secrets typed into HTTP base URLs, from #1778

  • Webhook tokens in base URLs (Bitrix24, Slack, Discord, Teams, Zapier, Make) and passwords in user:password@ move into encrypted variables on save, and in one pass at start-up. The base URL keeps the host and shows {{VAR}} where the secret was; calls resolve to the original URL.

After upgrading

  • The server log shows one line from the start-up pass with how many base URLs were moved. Nobody has to open or save connectors.
  • In a restricted workspace, members no longer see other members' MCP servers. A restricted member who connects an AI client is offered their own server; when that is their only server, the consent grants the workspace connection, where roles decide the tools.

No database migration. Cloud and self-hosted behave the same.

Checks on this branch

  • Backend npx tsc --noEmit: clean. npm run lint:check: 0 errors, 11 warnings already on main.
  • Frontend npx tsc --noEmit: clean.
  • npx jest src/settings src/roles src/mcp-servers src/users plus the base-URL secret specs: 31 suites passed, 3 skipped (env-gated), 2,130 tests passed.
  • generate-llms-txt, generate-cli-operations regenerated; adapter-count --check OK.
  • Added the visibility decision for the new RolesController.listMembers route (admin).

Closes #1777, closes #1778, closes #1779.

Access is the union of all role assignments, but the roles pages showed
and edited only the deprecated single users.mcpRoleId, so a role granted
by a single sign-on group stayed invisible. Add GET /api/roles/members
with all assignments and the connectors they reach, edit manual roles
through PUT /api/roles/assignments/:userId, mark synced and all-workspace
roles read-only, and return mcpRoles from GET /api/users.
A hand-made REST connector whose base URL carries its credential in the
path (a Bitrix24 inbound webhook, /rest/<user>/<code>/) kept the code in
plaintext in connectors.base_url and returned it to admins and the
owner. The secret-literal extraction on save did not know these shapes.

- Detector: vendor-anchored rules for Bitrix24 (cloud and self-hosted),
  Slack, Discord, Microsoft Teams, Zapier and Make webhook URLs, and the
  password in scheme://user:password@ for every HTTP connector type.
  Power Automate sig=, Google Chat key/token and Telegram were already
  covered by the query and token rules.
- Save: only the secret segment moves into a variable named so that
  isSecretName masks it; calls interpolate {{VAR}} verbatim, so the URL
  sent is unchanged.
- Start-up pass repairBaseUrlSecrets, run after the database pass: same
  rules minus the long-random-token heuristic, compare-and-swap on
  base URL and updatedAt, strict decryption of the variables, one
  summary log line with ids and counts only.
- API output masks a secret still in an HTTP base URL (and the catalog
  baseline) as ********; a form that sends the masked URL back keeps
  the stored one, a URL edited around the mask is refused.
In a restricted workspace a member who is not an admin used to see every
MCP server holding a connector they could see, with its name, owner,
connectors, endpoint and usage. They now see only the servers they own,
on every route that lists, reads, counts or reports servers: the servers
API (reads and writes answer the unknown-id 404), the server picker and
consent page, connections, API keys, connector detail, the audit log,
tool performance and breakdowns, and the server links on the shared MCP
endpoint. A restricted member with only their own server is granted the
workspace connection, where their roles decide the tools.

File Search detail routes answer 404 unless the member owns the
connector, also for one shared through their roles. The catalog's
installed flags count only connectors the member can see, and testing
values for an existing connector is limited to its owner or an admin.
member-visibility.routes.ts records, for each controller handler, what
a member who is not an admin gets in a restricted workspace. A spec
reads every controller through Nest route metadata and fails on a route
without a decision or a decision without a route, and checks admin-only
and scoped decisions against the code.

MemberVisibilityInterceptor enforces the admin-when-restricted
decisions (knowledge graph and skills reads, learning projects, plan
fit) without changing those controllers. An integration spec runs the
restricted VIEWER scenario against PostgreSQL.
@helpcodeai
helpcodeai requested a review from D3nisty as a code owner November 17, 2026 19:15
@helpcodeai
helpcodeai merged commit cbbbf3b into main Nov 17, 2026
17 checks passed
@helpcodeai
helpcodeai deleted the release/v0.55.4 branch November 17, 2026 19:51
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant