Skip to content

Remove Deprecated Gemini Sampling Parameters - #132

Open
Amazing-Stardom wants to merge 2 commits into
masterfrom
fix/gemini-config
Open

Amazing-Stardom wants to merge 2 commits into
masterfrom
fix/gemini-config

Conversation

@Amazing-Stardom

@Amazing-Stardom Amazing-Stardom commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Updated the langchaingo Go library to the latest version (v0.1.15).
  • Changed the default AI provider and model shown in the UI to OpenRouter with DeepSeek Pro v4 (deepseek/deepseek-pro-v4).
  • Updated the helper text and backend model catalog so DeepSeek Pro v4 is automatically selected as default.

Validation

  • Ran go mod tidy to make sure all Go dependencies are clean and matched.
  • Ran npx tsc --noEmit in the UI directory to ensure there are no frontend type errors.

Checklist

  • This PR fulfills an agreed issue.
  • I kept the change narrow and scoped.
  • I ran the most specific relevant validation and described it above.
  • If I changed behavior, I called that out clearly in this PR.
  • If I touched UI, I attached a GIF or video walkthrough. This is required.
  • If this change touches security, disclosure flow, credentials, storage, network behavior, or licensing/entitlement enforcement, I reviewed SECURITY.md and updated related documentation if needed.
  • I have read and accept the Contributor License Agreement.

Notes For Reviewers

  • Creating a new connector for OpenRouter will now automatically fill in deepseek/deepseek-pro-v4 instead of leaving it empty or pointing to the older route.

@LiveReview-Bot

Copy link
Copy Markdown

Migrate Codebase to Gemini 3.8 Flash and Remove Sampling Parameters

Overview

The codebase migrates to Gemini 3.8 Flash as the default AI model. All integrations, scripts, and configuration templates now omit unsupported sampling parameters like temperature, top_p, and top_k.

Technical Highlights

  • internal/ai/gemini/gemini.go: Updates the default model constant to Gemini 3.8 Flash and strips unsupported generation configuration payloads.
  • internal/aiconnectors/connector.go: Adds conditional checks to omit temperature, top_p, and top_k options for Gemini models.
  • internal/ai/langchain/provider.go: Introduces buildCallOptions to conditionally exclude temperature settings for Gemini and Vertex AI.

Impact

  • Functionality: Standardizes model usage on Gemini 3.8 Flash and prevents API validation errors from unsupported settings.
  • Risk: Custom configurations or external scripts using removed sampling parameters will ignore those values.

@LiveReview-Bot

Copy link
Copy Markdown

Update Default AI Models and Remove Temperature Parameters

Overview

The system migrates to Gemini 3.8 Flash and DeepSeek Pro v4. It also removes deprecated temperature and sampling parameters across all AI providers.

Technical Highlights

  • internal/ai/gemini/gemini.go: Sets default model to Gemini 3.8 Flash and removes legacy temperature fields.
  • internal/aiconnectors/connector.go: Adds helper logic to bypass temperature and sampling parameters for Gemini providers.
  • config/livereview.toml.example: Updates default sample configuration to use the new Gemini and DeepSeek models.

Impact

  • Functionality: Modernizes default AI models and prevents invalid parameter errors on Gemini APIs.
  • Risk: Existing custom configurations relying on removed temperature parameters may require manual cleanup.

@Amazing-Stardom
Amazing-Stardom marked this pull request as ready for review October 11, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants