Feature/eap full form by shreeyash07 · Pull Request #2122 · IFRCGo/go-web-app

shreeyash07 · 2025-12-04T09:38:24Z

Summary

Implement of full eap form with add edit functionality

Depends On

IFRCGo/go-api#2590

Changes

Add and edit form functionality
Add proper guidance text in the form fields
Add Input component for contact, approaches, indicators other form fields
Add approval modal for eap full form

This PR Ensures:

No typos or grammatical errors
No conflict markers left in the code
No unwanted comments, temporary files, or auto-generated files
No inclusion of secret keys or sensitive data
No console.log statements meant for debugging
All CI checks have passed

changeset-bot · 2025-12-04T09:38:28Z

⚠️ No Changeset found

Latest commit: 9e4a407

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

frozenhelium · 2025-12-22T08:01:19Z

Do not prefix string key with namespace

frozenhelium · 2025-12-22T08:29:21Z

Do not prefix string key with namespace, lets remove unused keys

frozenhelium · 2025-12-22T08:30:11Z

+function getNextStep(current: TabKeys, direction: 1 | -1) {
+    if (direction === 1) {
+        const mapping: { [key in TabKeys]?: TabKeys } = {
+            overview: 'riskAnalysis',
+            riskAnalysis: 'triggerModel',
+            triggerModel: 'selectionActions',
+            selectionActions: 'eapActivation',
+            eapActivation: 'meal',
+            meal: 'nationalSocietyCapacity',
+            nationalSocietyCapacity: 'financeLogistics',
+        };
+        return mapping[current];
+    }
+    if (direction === -1) {
+        const mapping: { [key in TabKeys]?: TabKeys } = {
+            financeLogistics: 'nationalSocietyCapacity',
+            nationalSocietyCapacity: 'meal',
+            meal: 'eapActivation',
+            eapActivation: 'selectionActions',
+            selectionActions: 'triggerModel',
+            triggerModel: 'riskAnalysis',
+            riskAnalysis: 'overview',
+        };
+        return mapping[current];
+    }
+    return undefined;
+}


Create a utility function and reuse it

AdityaKhatri · 2025-12-31T10:14:23Z

+            alert.show('Status updated successfully!', { variant: 'success' });
+        },
+        formData: true,
+        onFailure: () => {
+            alert.show('Failed to update the status!', { variant: 'danger' });


Add translations

AdityaKhatri · 2025-12-31T10:29:19Z

+                    <NumberInput
+                        label={strings.financeTotalBudgetLabel}
+                        name="total_budget"
+                        value={value?.total_budget}


As value is always defined, I don't think we need a ? here

AdityaKhatri · 2025-12-31T10:31:47Z

+                        fileIdToUrlMap={fileIdToUrlMap}
+                        onChange={setFieldValue}
+                        url="/api/v2/eap-file/multiple/"
+                        value={value?.meal_relevant_files}


In here too

AdityaKhatri · 2025-12-31T10:33:37Z

+
+    const strings = useTranslation(i18n);
+    const error = getErrorObject(formError);
+    const noop = () => { };


Why is there here? Add note.

AdityaKhatri · 2025-12-31T10:34:42Z

+                        onChange={setFieldValue}
+                        disabled={disabled}
+                    />
+                </InputSection>
+                <InputSection
+                    title={strings.objectiveTitle}
+                    description={strings.objectiveDescription}
+                    withAsteriskOnTitle
+                >
+                    <TextArea
+                        label={strings.workWithGovernmentDescriptionLabel}
+                        name="objective"
+                        value={value?.objective}


Why aren't errors handled here?

AdityaKhatri · 2025-12-31T10:41:12Z

+                        emptyMessage={strings.noIndicatorsMessage}
+                    >
+                        <ListView layout="block">
+                            {value.indicators?.map((indicator, i) => (


Add NonFieldError plz

AdityaKhatri · 2025-12-31T10:41:59Z

+    const selectedSectors = value?.planned_operations?.map(
+        ({ sector }) => sector,
+    );


AdityaKhatri · 2025-12-31T10:42:13Z

+    const selectedApproaches = value?.enable_approaches?.map(
+        ({ approach }) => approach,
+    );


useMemo pls

AdityaKhatri · 2025-12-31T10:44:19Z

AdityaKhatri · 2025-12-31T10:50:56Z

+    const latestFullEapId = eapDetailResponse?.full_eap_details?.toSorted(
+        (a, b) => compareNumber(a.version, b.version, -1),
+    )?.[0]?.id;


frozenhelium · 2026-01-08T12:51:28Z

+        [onFieldChange],
+    );
+
+    return (


This section currently looks like:

But should look like:

There a a lot of other section which should be laid out similary

Missed this comment can we do this in another PR?

resolved this changes please check @frozenhelium

shreeyash07 had a problem deploying to test December 4, 2025 09:38 — with GitHub Actions Failure

shreeyash07 changed the base branch from develop to project/early-action-protocols December 4, 2025 09:38

shreeyash07 had a problem deploying to test December 4, 2025 09:38 — with GitHub Actions Failure

frozenhelium force-pushed the project/early-action-protocols branch 3 times, most recently from d10a0db to 5ccc1bc Compare December 11, 2025 10:04

shreeyash07 force-pushed the feature/eap-full-form branch 2 times, most recently from 0adbb63 to c9c84d0 Compare December 12, 2025 05:10

shreeyash07 temporarily deployed to test December 12, 2025 05:10 — with GitHub Actions Inactive

shreeyash07 temporarily deployed to test December 12, 2025 05:11 — with GitHub Actions Inactive

shreeyash07 force-pushed the feature/eap-full-form branch from c9c84d0 to a172ce2 Compare December 12, 2025 05:33

shreeyash07 temporarily deployed to test December 12, 2025 05:33 — with GitHub Actions Inactive

shreeyash07 temporarily deployed to test December 12, 2025 05:34 — with GitHub Actions Inactive

frozenhelium force-pushed the project/early-action-protocols branch from e52c062 to 4c88096 Compare December 15, 2025 06:59

shreeyash07 force-pushed the feature/eap-full-form branch 2 times, most recently from f8aabc4 to 1cb8802 Compare December 15, 2025 10:45

shreeyash07 temporarily deployed to test December 15, 2025 10:45 — with GitHub Actions Inactive

shreeyash07 temporarily deployed to test December 15, 2025 10:46 — with GitHub Actions Inactive

shreeyash07 temporarily deployed to test December 15, 2025 10:47 — with GitHub Actions Inactive

shreeyash07 force-pushed the feature/eap-full-form branch from 1cb8802 to 04d7790 Compare December 19, 2025 11:14

shreeyash07 temporarily deployed to test December 19, 2025 11:14 — with GitHub Actions Inactive

shreeyash07 temporarily deployed to test December 19, 2025 11:15 — with GitHub Actions Inactive

shreeyash07 temporarily deployed to test December 19, 2025 11:16 — with GitHub Actions Inactive

frozenhelium requested changes Dec 22, 2025

View reviewed changes

frozenhelium force-pushed the project/early-action-protocols branch from 4c88096 to 84b47e5 Compare December 24, 2025 04:56

shreeyash07 force-pushed the feature/eap-full-form branch from 1131875 to 1bdee06 Compare December 30, 2025 05:30

shreeyash07 temporarily deployed to test December 30, 2025 05:30 — with GitHub Actions Inactive

shreeyash07 temporarily deployed to test December 30, 2025 05:31 — with GitHub Actions Inactive

shreeyash07 temporarily deployed to test December 30, 2025 16:54 — with GitHub Actions Inactive

AdityaKhatri requested changes Dec 31, 2025

View reviewed changes

shreeyash07 temporarily deployed to test January 2, 2026 05:31 — with GitHub Actions Inactive

shreeyash07 temporarily deployed to test January 2, 2026 05:32 — with GitHub Actions Inactive

shreeyash07 temporarily deployed to test January 2, 2026 05:33 — with GitHub Actions Inactive

shreeyash07 temporarily deployed to test January 2, 2026 06:42 — with GitHub Actions Inactive

shreeyash07 temporarily deployed to test January 2, 2026 06:43 — with GitHub Actions Inactive

shreeyash07 temporarily deployed to test January 2, 2026 06:44 — with GitHub Actions Inactive

shreeyash07 temporarily deployed to test January 2, 2026 14:09 — with GitHub Actions Inactive

shreeyash07 temporarily deployed to test January 2, 2026 14:10 — with GitHub Actions Inactive

shreeyash07 temporarily deployed to test January 2, 2026 14:11 — with GitHub Actions Inactive

shreeyash07 force-pushed the feature/eap-full-form branch from 79e1e7a to 2da8205 Compare January 8, 2026 08:28

shreeyash07 temporarily deployed to test January 8, 2026 08:28 — with GitHub Actions Inactive

shreeyash07 temporarily deployed to test January 8, 2026 08:29 — with GitHub Actions Inactive

shreeyash07 temporarily deployed to test January 8, 2026 08:30 — with GitHub Actions Inactive

frozenhelium reviewed Jan 8, 2026

View reviewed changes

shreeyash07 added 9 commits January 11, 2026 16:38

feat(full-eap): add and edit functionality of full eap form

f1aa0ef

feat(full-eap): Add tooltip in necessary title of the forms

ee1f793

feat(full-eap): Add contact Input for full eap overview section

ba54f58

feat(full-eap): Add approval modal in full eap form

c9e330f

fix(full-eap): add missing translation strings

5e61e0a

feat(full-eap): make formatSourceLink common function

f9ef904

fix(full-eap): update accept file in eap forms

7a14c6d

feat(full-eap): read only for the full eap form

51f5451

feat(eap-full): add updated_checklist_file file input

49b2a76

frozenhelium approved these changes Jan 13, 2026

View reviewed changes

fix(eap): update editable condition in eap table

9e4a407

Conversation

shreeyash07 commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Depends On

Changes

This PR Ensures:

Uh oh!

changeset-bot bot commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

shreeyash07 commented Dec 4, 2025 •

edited

Loading

changeset-bot bot commented Dec 4, 2025 •

edited

Loading