Skip to content

feat(account-settings): add email alerting preferences#2229

Open
subinasr wants to merge 3 commits intoproject/email-alertsfrom
feature/add-email-preferences
Open

feat(account-settings): add email alerting preferences#2229
subinasr wants to merge 3 commits intoproject/email-alertsfrom
feature/add-email-preferences

Conversation

@subinasr
Copy link
Copy Markdown
Collaborator

@subinasr subinasr commented Feb 7, 2026 •
edited by frozenhelium
Loading

Summary

Add email preferences in account settings.

2026-03-17-201419 2026-03-17-201248

Addresses

Add a section in notification preferences for montandon alerts

Depends On

IFRCGo/go-api#2648

Changes

  • Add notification preferences for montandon alerts

This PR Ensures:

  • No typos or grammatical errors
  • No conflict markers left in the code
  • No unwanted comments, temporary files, or auto-generated files
  • No inclusion of secret keys or sensitive data
  • No console.log statements meant for debugging
  • All CI checks have passed

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Feb 7, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: 74b7254

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@subinasr subinasr force-pushed the feature/add-email-preferences branch 4 times, most recently from a3a4031 to 1ff0ad5 Compare February 9, 2026 06:53
@subinasr subinasr changed the base branch from develop to project/email-alerts February 9, 2026 06:54
@subinasr subinasr requested a review from frozenhelium February 9, 2026 06:56
@subinasr subinasr marked this pull request as ready for review February 9, 2026 06:56
shreeyash07
shreeyash07 reviewed Feb 9, 2026
View reviewed changes
Comment thread app/src/views/AccountNotifications/EmailPreferences/SubscriptionModal/index.tsx Outdated
Comment thread app/src/views/AccountNotifications/EmailPreferences/index.tsx Outdated
Comment thread app/src/views/AccountNotifications/EmailPreferences/index.tsx Outdated
@subinasr subinasr force-pushed the feature/add-email-preferences branch from b921ef0 to 64c93e4 Compare February 10, 2026 05:43
@subinasr subinasr requested a review from shreeyash07 February 10, 2026 05:43
@frozenhelium frozenhelium force-pushed the feature/add-email-preferences branch 2 times, most recently from 9dd1c1f to 9839edf Compare March 17, 2026 14:31
@frozenhelium frozenhelium force-pushed the feature/add-email-preferences branch 2 times, most recently from 07368c4 to 82a14c7 Compare March 17, 2026 14:34
frozenhelium
frozenhelium requested changes Mar 17, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@frozenhelium frozenhelium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should upda

Comment thread app/src/views/AccountNotifications/EmailPreferences/SubscriptionModal/index.tsx
updateSubscription({
...formValues,
// NOTE: @frozenhelium Will undefined be set to null by default?
alert_per_day: isNotDefined(formValues.alert_per_day)
Copy link
Copy Markdown
Member

@frozenhelium frozenhelium Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use defaultValue: nullValue in the form schema

Comment thread app/src/views/AccountNotifications/EmailPreferences/SubscriptionModal/index.tsx
createSubscription({
...formValues,
// NOTE: @frozenhelium Will undefined be set to null by default?
alert_per_day: isNotDefined(formValues.alert_per_day)
Copy link
Copy Markdown
Member

@frozenhelium frozenhelium Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use defaultValue: nullValue in the form schema

Comment thread app/src/views/AccountNotifications/EmailPreferences/SubscriptionModal/index.tsx
}),
);
},
// TODO: handle failure
Copy link
Copy Markdown
Member

@frozenhelium frozenhelium Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it

Comment thread app/src/views/AccountNotifications/EmailPreferences/SubscriptionModal/schema.ts
Copy link
Copy Markdown
Member

@frozenhelium frozenhelium Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make the schema conditional so that at least one of the country or region is required. Let's do the necessary adjustment in the server side as well!

@frozenhelium frozenhelium force-pushed the feature/add-email-preferences branch from 82a14c7 to 74b7254 Compare March 17, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frozenhelium frozenhelium frozenhelium requested changes

@shreeyash07 shreeyash07 Awaiting requested review from shreeyash07

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@subinasr @frozenhelium @shreeyash07