Skip to content

feat(qy): QY-compatible CPU device header fix - #77

Closed
Ceng23333 wants to merge 1 commit into
InfiniTensor:masterfrom
Ceng23333:feat/qy-cpu-device-header
Closed

feat(qy): QY-compatible CPU device header fix#77
Ceng23333 wants to merge 1 commit into
InfiniTensor:masterfrom
Ceng23333:feat/qy-cpu-device-header

Conversation

@Ceng23333

@Ceng23333 Ceng23333 commented Oct 14, 2026 •
edited
Loading

Copy link
Copy Markdown

Summary

Add CPU GetMemorySpace specialization so the post-refactor Infini stack (QY MiniCPM5 pin) can build against InfiniCCL.

Changes

  • src/devices/cpu/device_.h: provide GetMemorySpace returning MemorySpace::kHost for CPU device.

Validation

  • Cluster / example programs: N/A for this 1-file header specialization (no NCCL path change). Compile-time fix only.
  • Cherry-picked from Ceng tip 8dda36c onto current master; clang-format applied.
  • Integration-validated via InfiniTensorWorktree release/2026.10.13-qy-minicpm5-16a3-fa-longctx-cudagraph.

Related

Made with Cursor

Stack PR index (merge order)

  1. InfiniOps: feat(qy): QY ops backend with FA and longctx MoE/RoPE kernels InfiniOps#1002
  2. InfiniRT: feat(qy): enable QY CUDA runtime device backend InfiniRT#49
  3. InfiniCCL: feat(qy): QY-compatible CPU device header fix #77
  4. InfiniCore: chore(qy): pin InfiniRT/Ops/CCL for MiniCPM5 FA/longctx InfiniCore#1575
  5. InfiniLM: feat(qy): MiniCPM5 FA, longctx MoE/RoPE, CUDA-graph capture safety InfiniLM#597 → base refactor/adopt-modern-infini-stack

ITW pin: https://github.com/Ceng23333/InfiniTensorWorktree/tree/release/2026.10.13-qy-minicpm5-16a3-fa-longctx-cudagraph

@Ceng23333 @cursoragent
feat(qy): QY-compatible CPU device header fix
13e5f61 
Allow the QY stack to build against InfiniCCL with the CPU device header
adjustments needed by the post-refactor worktree.

Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Oct 14, 2026
Open
Open
Open
Open
@Ceng23333

Ceng23333 commented Oct 15, 2026

Copy link
Copy Markdown
Author

QY required smoke (PR head)

  • Head SHA: 13e5f613693c35de09e1266c9dd1a50a60a67e82
  • Host: Denglin QY build container
  • Command: InfiniLM build_infini_stack.py --backend qy (CCL configure/build/install, TP1 CPU/OMPI)
  • Result: PASS (compile/link OK)
  • Log: …/logs/prhead-verify/stack-m0-build-test.log

Notes: no QY NCCL / TP2 smoke (out of scope for this PR).

@Ziminli

Ziminli commented Oct 15, 2026

Copy link
Copy Markdown
Collaborator

This PR has been closed as duplicate work. The same fix has been applied in #79. Your contribution is appreciated and has been acknowledged.

Additionally, please note that InfiniCCL, as a project under the InfiniTensor organization, does not currently accept AI/agent as a co-author.

@Ziminli Ziminli closed this Oct 15, 2026
@Ceng23333

Ceng23333 commented Oct 15, 2026

Copy link
Copy Markdown
Author

QY required smoke (PR head) — detailed

  • Head SHA: 13e5f613693c35de09e1266c9dd1a50a60a67e82
  • Host: Denglin QY build container
  • Command: InfiniLM build_infini_stack.py --backend qy (CCL configure / build / install)
  • Overall: PASS
  • Log: …/logs/prhead-verify/stack-m0-build-test.log, stack-m2-build-test.log
Step Config Result
cmake configure WITH_NCCL=OFF, devices [cpu], backends [ompi] PASS
cmake --build …/infiniccl libinfiniccl.so PASS
cmake --install prefix lib/libinfiniccl.so + headers + icclrun PASS
Stack consume (m0) linked into QY stack with RT 95d30fe / Ops ed0b40d PASS
Stack consume (m2 FA) same, full 23-op QY config PASS

No QY NCCL / TP2 AllReduce smoke (out of scope for this 1-file CPU header PR).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Ceng23333 @Ziminli