Stats interface by pixup1 · Pull Request #11 · InsaLan/tmt2

pixup1 · 2025-01-29T14:16:07Z

Add an interface for visualizing statistics, as well as the backend API endpoints to fetch them. Since #15 was merged, it also adds a Data Management tab that makes it possible to download and restore backups of the database.

Fix #3
Fix #13

Ecnama · 2025-11-04T16:28:41Z

I think matchId is not really readable as a user, and it could be replaced by more usable information in some cases :

In the player stats view : I think opponent and timestamp would be better

In the match stats view : teams name could be bigger, and the matchId smaller, under the score, and maybe copyable ?

In the matches view : matchId could be somewhere else (in 4th-5th column ?) as it is not what players will seek first

Ecnama · 2025-11-04T16:30:00Z

Could the switch and the vertical bar be aligned ? Or does it look worse ?

Ecnama · 2025-11-04T16:35:56Z

K/D, HS% and ADR should all be formatted with two decimals, as they are all float

pixup1 · 2025-11-04T20:04:40Z

Player names should be displayed below team names in the match view

EDIT: this is normal because the teams table is empty

pixup1 · 2025-11-04T20:07:13Z

Date should be displayed in DD/MM/YYYY format

pixup1 · 2025-11-04T20:19:15Z

Could the switch and the vertical bar be aligned ? Or does it look worse ?

idk how to do that but i don't think it really matters tbh lol

pixup1 · 2025-11-05T20:32:13Z

TODO: show "No data" in table when empty.

Copilot

Pull Request Overview

This PR adds comprehensive statistics tracking and data management features to the Tournament Match Tracker application, including player stats, match stats, database management capabilities, and significant UI improvements.

Key changes:

Statistics tracking system with player/match stats APIs and frontend pages
Database management features (download, upload, delete operations)
UI/UX improvements including new navigation, logo updates, and improved 404 page
New dependencies: multer for file uploads and node-cache for caching

Reviewed Changes

Copilot reviewed 32 out of 44 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
backend/src/statsController.ts	New controller providing REST endpoints for statistics queries
backend/src/storageController.ts	New controller for database download/upload/management operations
backend/src/statsLogger.ts	Enhanced with caching and query functions for stats retrieval
backend/src/storage.ts	Added DB download, replace, and empty operations
frontend/src/pages/stats.tsx	New comprehensive stats pages for matches and players
frontend/src/pages/dataManagement.tsx	New page for database management operations
frontend/src/components/StatsTable.tsx	Reusable table component with sorting, filtering, and grouping
frontend/src/utils/uploadUserFile.ts	Utility for file upload via browser
frontend/src/utils/mustConfirm.tsx	Confirmation modal utility (refactored from .ts)
common/types/stats.ts	Type definitions for player and match statistics

Files not reviewed (2)

backend/package-lock.json: Language not supported
frontend/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

pixup1 · 2025-11-06T21:48:19Z

thx @copilot ur da best <3 (don't take my job pls)

Ecnama

LGTM

* Add stats management page * Make DB download functional + reorganize data management layout * Add confirmation modal for database operations * Replace and factorize confirmation modal * Authenticate frontend routes * Implement DB management functions

…hes are live

* Add stats page * Add backend API endpoints for stats * Add players and matches stats pages * Working stats views * Add match-specific stats page * Add player-specific stats view * Group stats by match in player stats * Factorize stats tables * Add ability to sort by column * Handle errors (a bit) better * Handle 404s * Improve frontend error handling * Adapt stats for new tables * Add team players to match view * Insalan rebrand + highlight current tab * Fix logo color + tweak title * Add proper 404 page * Add copy steamID button * Change error color to theme coor * Fix messed up rebase * Fix data table name and clean files * Various stats fixes + add color to stats * Add data management page (#15) * Add stats management page * Make DB download functional + reorganize data management layout * Add confirmation modal for database operations * Replace and factorize confirmation modal * Authenticate frontend routes * Implement DB management functions * Revert 2e241a1 because it's annoying and not really useful * Add empty message to stats table + forbid editing database while matches are live * Invalidate cache on DB operations * Center float in table * Add stats search bar and links in details * Fix a few things * Fix colors in light theme * Fix DB replacement --------- Co-authored-by: Ecnama <amance.github@famille-graindorge.fr>

pixup1 self-assigned this Jan 29, 2025

pixup1 linked an issue Jan 29, 2025 that may be closed by this pull request

Add frontend scoreboard #3

Closed

Ecnama force-pushed the stats-logger branch 2 times, most recently from b9c5bf0 to 37cff11 Compare January 31, 2025 10:37

pixup1 force-pushed the stats-interface branch 2 times, most recently from 2375f86 to c347fdb Compare February 5, 2025 13:24

pixup1 force-pushed the stats-interface branch from f4397e5 to 065e80d Compare October 22, 2025 21:07

Ecnama force-pushed the stats-logger branch from 4d27247 to 0e8997f Compare October 27, 2025 13:28

Base automatically changed from stats-logger to dev October 28, 2025 16:43

pixup1 force-pushed the stats-interface branch from 4f04bbc to 8297410 Compare November 4, 2025 15:46

pixup1 marked this pull request as ready for review November 6, 2025 21:04

pixup1 requested review from Ecnama and Copilot November 6, 2025 21:04

Copilot AI reviewed Nov 6, 2025

View reviewed changes

Comment thread frontend/src/utils/uploadUserFile.ts Outdated

Comment thread frontend/src/utils/uploadUserFile.ts

Comment thread frontend/src/components/StatsTable.tsx Outdated

Comment thread backend/src/storage.ts Outdated

Comment thread frontend/src/App.tsx Outdated

Copilot AI mentioned this pull request Nov 6, 2025

Stats interface #21

Closed

InsaLan deleted a comment from Copilot AI Nov 6, 2025

Ecnama requested changes Nov 7, 2025

View reviewed changes

Comment thread backend/src/statsLogger.ts Outdated

Comment thread frontend/src/components/StatsTable.tsx

pixup1 requested a review from Ecnama November 7, 2025 08:08

Ecnama approved these changes Nov 7, 2025

View reviewed changes

pixup1 added 3 commits November 7, 2025 09:14

Add stats page

23223e7

Add backend API endpoints for stats

45140f3

Add players and matches stats pages

6fcab15

pixup1 and others added 23 commits November 7, 2025 09:14

Add ability to sort by column

cf21ce9

Handle errors (a bit) better

012797c

Handle 404s

158c219

Improve frontend error handling

5493736

Adapt stats for new tables

19f28b1

Add team players to match view

8ae3d78

Insalan rebrand + highlight current tab

8dcd344

Fix logo color + tweak title

46ffde1

Add proper 404 page

2447e7b

Add copy steamID button

d90c1fc

Change error color to theme coor

c506967

Fix messed up rebase

1ebeae8

Fix data table name and clean files

4126c16

Various stats fixes + add color to stats

6619daa

Add data management page (#15)

9c9cb58

* Add stats management page * Make DB download functional + reorganize data management layout * Add confirmation modal for database operations * Replace and factorize confirmation modal * Authenticate frontend routes * Implement DB management functions

Revert 2e241a1 because it's annoying and not really useful

25d8a0f

Add empty message to stats table + forbid editing database while matc…

f10a583

…hes are live

Invalidate cache on DB operations

040c8f1

Center float in table

9546ecf

Add stats search bar and links in details

82f24e6

Fix a few things

eb4d7b7

Fix colors in light theme

ef3653b

Fix DB replacement

c251d50

pixup1 force-pushed the stats-interface branch from c9a3bea to c251d50 Compare November 7, 2025 08:33

Ecnama approved these changes Nov 7, 2025

View reviewed changes

pixup1 merged commit fdc96b7 into dev Nov 7, 2025

Ecnama deleted the stats-interface branch November 10, 2025 12:39

Conversation

pixup1 commented Jan 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Ecnama commented Nov 4, 2025

Uh oh!

Ecnama commented Nov 4, 2025

Uh oh!

Ecnama commented Nov 4, 2025

Uh oh!

pixup1 commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pixup1 commented Nov 4, 2025

Uh oh!

pixup1 commented Nov 4, 2025

Uh oh!

pixup1 commented Nov 5, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pixup1 commented Nov 6, 2025

Uh oh!

Uh oh!

Uh oh!

Ecnama left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pixup1 commented Jan 29, 2025 •

edited

Loading

pixup1 commented Nov 4, 2025 •

edited

Loading