Repository navigation
Fix qualifier leak on repeated assignment in ApplyTypeAnnotationsVisitor - #1480
Open
watercrossing wants to merge 1 commit into
Open
watercrossing wants to merge 1 commit into
watercrossing wants to merge 1 commit into
Conversation
_annotate_single_target did not pop the target name from self.qualifier when the name had already been annotated (the second assignment, added in Instagram#956), so all later definitions in the module were looked up under the wrong qualified name and left unannotated. Pop it before the already_annotated check. Fixes Instagram#1479
meta-cla
Bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_annotate_single_targetdid not pop the target name fromself.qualifierwhen the name had already been annotated (the second assignment, the branch added in #956), so all later definitions in the module were looked up under the wrong qualified name and left unannotated. This pops it before thealready_annotatedcheck, so every path pops it.Fixes #1479.
Test Plan
Added
toplevel_then_functionandclass_then_method_and_functiontotest_no_duplicate_annotations; both fail before the change and pass after it. All 95 tests intest_apply_type_annotations.pypass.