Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GatherExportsVisitorignores literal__all__.append()and.extend()calls. Consequently,RemoveUnusedImportsCommandcan delete an import that the module explicitly exports through one of those calls.Recognize direct, unconditional module-level expression statements using literal strings or literal list/tuple additions. Structural receiver checks exclude indirect call/subscript receivers, and module-level call indexing excludes deferred/conditional expressions. Existing assignment gathering is preserved.
Refs #1481. This implements literal additions; removal remains conservative because unresolved additions or aliases can leave duplicate exported names. The full issue should remain open for sound removal analysis.
Test Plan
uv run poe test: 2,167 tests, no unexpected failures; 14 skips and two expected failures. Coverage 95.8%.uv run poe format,uv run poe lintanduv run poe typecheckpass; diff check clean.