Repository navigation
Parse parenthesized targets in annotated assignments - #1486
Shriraj1901 wants to merge 1 commit into
Conversation
`(n): int = 1` is valid Python, but the native parser rejected it:
the annotated assignment rule only accepted a bare name or an
attribute/subscript target before the colon. CPython's grammar also
allows `'(' single_target ')'` there, and the rule even carried a TODO
about the missing clause.
Add that alternative, with a parser test and a roundtrip fixture.
Fixes Instagram#1011
|
Hi @Shriraj1901! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
(n): int = 1is valid Python, but the native parser rejected it: the annotated assignment rule only accepted a bare name or an attribute/subscript target before the colon. CPython's grammar also allows'(' single_target ')'there, and the rule even carried a TODO about the missing clause.Add that alternative, with a parser test and a roundtrip fixture.
Fixes #1011
Summary
Test Plan