Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ran
cargo clippy --fixso that the clippy linting errors would be automatically fixed.There were 4 imports that were removed from
native/libcst/src/nodes/mod.rs:DeflatedAsynchronous as AsynchronousDeflatedFormattedStringText as FormattedStringTextDeflatedTemplatedStringText as TemplatedStringTextDeflatedImportStar as ImportStarThese changes were reverted before pushing up because it seemed like those are important to be forwarded to the python side of the package
Test Plan
All existing tests pass both rust and python
commands ran:
test results:
Ran 2161 tests in 154.787s OK (skipped=14, expected failures=2)Any changes please let me know