Repository navigation
Factor the Miniconda setup retry out into a local composite action - #3179
Merged
Merged
Conversation
Every conda job repeated the same pair of `conda-incubator/setup-miniconda` steps, a first attempt with `continue-on-error` and a `ReSetup miniconda` retry with identical inputs: 13 copies in 6 workflows, each pinning the action SHA twice. The new `.github/actions/setup-miniconda` action holds that pair once. Jobs pass only `miniforge-version`, `activate-environment` and either `environment-file` or `python-version` with `channels`; `use-mamba` and `conda-remove-defaults` were `'true'` everywhere and are fixed in the action. Related changes: - Jobs that check dpnp out into `source/` use the action from `./source/.github/actions/setup-miniconda`. - `cron-run-tests.yaml` had no checkout, so it gets a sparse one of `.github/actions`. - `cleanup_packages` checked `devops-tools` out over the dpnp tree, which would remove the action before its post step runs, so that checkout now goes to a `devops-tools/` subdirectory. - Dependabot scans `/.github/actions/*` too, so the moved pin keeps being bumped. - `.github/AGENTS.md` notes the action.
antonwolfy
requested review from
ndgrigorian and
vlad-perevezentsev
as code owners
November 8, 2026 18:23
Contributor
|
Array API standard conformance tests for dpnp=0.22.0dev2=np2py314h8d9cdd5_5 ran successfully. |
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
There was a problem hiding this comment.
🔵 Needs a closer look
Runner validation is still needed for nested setup-miniconda cleanup on Linux and Windows, particularly the upload, package-cleanup, and scheduled-test paths identified as untested before merge.
No open issues 🎉
What changed in this PR
Centralizes Miniconda setup and retry handling in a local composite action, replacing 13 duplicated step pairs across six dpnp CI workflows.
Changes:
- Adds a shared setup action with one retry and common conda settings.
- Updates workflow callers and checkout locations to support the local action.
- Extends Dependabot coverage to local actions and documents their use.
| File | Description |
|---|---|
.github/workflows/generate_coverage.yaml |
Uses the shared action for coverage setup. |
.github/workflows/cron-run-tests.yaml |
Adds a sparse checkout and uses the shared action. |
.github/workflows/conda-package.yml |
Migrates setup calls and isolates the devops-tools checkout. |
.github/workflows/conda-build-test.yml |
Migrates build and test setup calls. |
.github/workflows/check-onemath.yaml |
Migrates both oneMath setup calls. |
.github/workflows/build-sphinx.yml |
Uses the shared action for documentation setup. |
.github/dependabot.yml |
Includes local action directories in dependency updates. |
.github/AGENTS.md |
Documents the shared action and checkout-relative paths. |
.github/actions/setup-miniconda/action.yml |
Defines shared setup inputs, settings, and retry behavior. |
Review effort: Balanced
Collaborator
vlad-perevezentsev
approved these changes
Nov 11, 2026
vlad-perevezentsev
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Thank you @antonwolfy
github-actions Bot
added a commit
that referenced
this pull request
Nov 13, 2026
…3179) Every conda job repeated the same pair of `conda-incubator/setup-miniconda` steps: a first attempt with `continue-on-error`, then a `ReSetup miniconda` retry with identical inputs. That was 13 copies in 6 workflows, each pinning the action SHA twice. The new `.github/actions/setup-miniconda` composite action holds that pair once. Jobs pass only `miniforge-version`, `activate-environment` and either `environment-file` or `python-version` with `channels`. `use-mamba` and `conda-remove-defaults` were `'true'` everywhere, so they are fixed in the action. Other changes needed for it: - Jobs that check dpnp out into `source/` use the action from `./source/.github/actions/setup-miniconda`. - `cron-run-tests.yaml` had no checkout, so it gets a sparse one of `.github/actions`. - `cleanup_packages` checked `devops-tools` out over the dpnp tree. That would remove the action before `setup-miniconda`'s post step runs, so the checkout now goes to a `devops-tools/` subdirectory. - Dependabot's `directory: "/"` covers only `.github/workflows`, so `/.github/actions/*` is added and the moved pin keeps being bumped. - `.github/AGENTS.md` notes the action. actionlint and zizmor pass. zizmor reports 13 more low-severity `self-repository` notes, one per new `uses: ./...`, below the `medium` gate like the 2 already there. The `upload` and `cleanup_packages` jobs run only on `master` and `cron-run-tests.yaml` only on schedule or dispatch, so their first runs after merge are the real check for them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every conda job repeated the same pair of
conda-incubator/setup-minicondasteps: a first attempt withcontinue-on-error, then aReSetup minicondaretry with identical inputs. That was 13 copies in 6 workflows, each pinning the action SHA twice.The new
.github/actions/setup-minicondacomposite action holds that pair once. Jobs pass onlyminiforge-version,activate-environmentand eitherenvironment-fileorpython-versionwithchannels.use-mambaandconda-remove-defaultswere'true'everywhere, so they are fixed in the action.Other changes needed for it:
source/use the action from./source/.github/actions/setup-miniconda.cron-run-tests.yamlhad no checkout, so it gets a sparse one of.github/actions.cleanup_packagescheckeddevops-toolsout over the dpnp tree. That would remove the action beforesetup-miniconda's post step runs, so the checkout now goes to adevops-tools/subdirectory.directory: "/"covers only.github/workflows, so/.github/actions/*is added and the moved pin keeps being bumped..github/AGENTS.mdnotes the action.actionlint and zizmor pass. zizmor reports 13 more low-severity
self-repositorynotes, one per newuses: ./..., below themediumgate like the 2 already there. Theuploadandcleanup_packagesjobs run only onmasterandcron-run-tests.yamlonly on schedule or dispatch, so their first runs after merge are the real check for them.