Skip to content

Factor the Miniconda setup retry out into a local composite action - #3179

Merged
antonwolfy merged 2 commits into
masterfrom
setup-miniconda-action
Nov 13, 2026
Merged

antonwolfy merged 2 commits into
masterfrom
setup-miniconda-action

Conversation

@antonwolfy

Copy link
Copy Markdown
Contributor

Every conda job repeated the same pair of conda-incubator/setup-miniconda steps: a first attempt with continue-on-error, then a ReSetup miniconda retry with identical inputs. That was 13 copies in 6 workflows, each pinning the action SHA twice.

The new .github/actions/setup-miniconda composite action holds that pair once. Jobs pass only miniforge-version, activate-environment and either environment-file or python-version with channels. use-mamba and conda-remove-defaults were 'true' everywhere, so they are fixed in the action.

Other changes needed for it:

  • Jobs that check dpnp out into source/ use the action from ./source/.github/actions/setup-miniconda.
  • cron-run-tests.yaml had no checkout, so it gets a sparse one of .github/actions.
  • cleanup_packages checked devops-tools out over the dpnp tree. That would remove the action before setup-miniconda's post step runs, so the checkout now goes to a devops-tools/ subdirectory.
  • Dependabot's directory: "/" covers only .github/workflows, so /.github/actions/* is added and the moved pin keeps being bumped.
  • .github/AGENTS.md notes the action.

actionlint and zizmor pass. zizmor reports 13 more low-severity self-repository notes, one per new uses: ./..., below the medium gate like the 2 already there. The upload and cleanup_packages jobs run only on master and cron-run-tests.yaml only on schedule or dispatch, so their first runs after merge are the real check for them.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

Every conda job repeated the same pair of `conda-incubator/setup-miniconda` steps, a first attempt with `continue-on-error` and a `ReSetup miniconda` retry with identical inputs: 13 copies in 6 workflows, each pinning the action SHA twice.

The new `.github/actions/setup-miniconda` action holds that pair once. Jobs pass only `miniforge-version`, `activate-environment` and either `environment-file` or `python-version` with `channels`; `use-mamba` and `conda-remove-defaults` were `'true'` everywhere and are fixed in the action.

Related changes:
- Jobs that check dpnp out into `source/` use the action from `./source/.github/actions/setup-miniconda`.
- `cron-run-tests.yaml` had no checkout, so it gets a sparse one of `.github/actions`.
- `cleanup_packages` checked `devops-tools` out over the dpnp tree, which would remove the action before its post step runs, so that checkout now goes to a `devops-tools/` subdirectory.
- Dependabot scans `/.github/actions/*` too, so the moved pin keeps being bumped.
- `.github/AGENTS.md` notes the action.
@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Array API standard conformance tests for dpnp=0.22.0dev2=np2py314h8d9cdd5_5 ran successfully.
Passed: 1491
Failed: 0
Skipped: 6

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy self-assigned this Nov 8, 2026
@antonwolfy antonwolfy added this to the 0.22.0 release milestone Nov 8, 2026
@antonwolfy
antonwolfy requested a balanced review from Copilot November 8, 2026 19:56

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Runner validation is still needed for nested setup-miniconda cleanup on Linux and Windows, particularly the upload, package-cleanup, and scheduled-test paths identified as untested before merge.

No open issues 🎉

What changed in this PR

Centralizes Miniconda setup and retry handling in a local composite action, replacing 13 duplicated step pairs across six dpnp CI workflows.

Changes:

  • Adds a shared setup action with one retry and common conda settings.
  • Updates workflow callers and checkout locations to support the local action.
  • Extends Dependabot coverage to local actions and documents their use.
File Description
.github/​workflows/​generate_coverage.yaml Uses the shared action for coverage setup.
.github/​workflows/​cron-run-tests.yaml Adds a sparse checkout and uses the shared action.
.github/​workflows/​conda-package.yml Migrates setup calls and isolates the devops-tools checkout.
.github/​workflows/​conda-build-test.yml Migrates build and test setup calls.
.github/​workflows/​check-onemath.yaml Migrates both oneMath setup calls.
.github/​workflows/​build-sphinx.yml Uses the shared action for documentation setup.
.github/​dependabot.yml Includes local action directories in dependency updates.
.github/​AGENTS.md Documents the shared action and checkout-relative paths.
.github/​actions/​setup-miniconda/​action.yml Defines shared setup inputs, settings, and retry behavior.

Review effort: Balanced

@coveralls

coveralls commented Nov 8, 2026 •

Copy link
Copy Markdown
Collaborator

Coverage Status

coverage: 84.269%. remained the same — setup-miniconda-action into master

@vlad-perevezentsev vlad-perevezentsev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you @antonwolfy

@antonwolfy
antonwolfy merged commit 880aa60 into master Nov 13, 2026
46 checks passed
@antonwolfy
antonwolfy deleted the setup-miniconda-action branch November 13, 2026 12:07
github-actions Bot added a commit that referenced this pull request Nov 13, 2026
…3179)

Every conda job repeated the same pair of
`conda-incubator/setup-miniconda` steps: a first attempt with
`continue-on-error`, then a `ReSetup miniconda` retry with identical
inputs. That was 13 copies in 6 workflows, each pinning the action SHA
twice.

The new `.github/actions/setup-miniconda` composite action holds that
pair once. Jobs pass only `miniforge-version`, `activate-environment`
and either `environment-file` or `python-version` with `channels`.
`use-mamba` and `conda-remove-defaults` were `'true'` everywhere, so
they are fixed in the action.

Other changes needed for it:
- Jobs that check dpnp out into `source/` use the action from
`./source/.github/actions/setup-miniconda`.
- `cron-run-tests.yaml` had no checkout, so it gets a sparse one of
`.github/actions`.
- `cleanup_packages` checked `devops-tools` out over the dpnp tree. That
would remove the action before `setup-miniconda`'s post step runs, so
the checkout now goes to a `devops-tools/` subdirectory.
- Dependabot's `directory: "/"` covers only `.github/workflows`, so
`/.github/actions/*` is added and the moved pin keeps being bumped.
- `.github/AGENTS.md` notes the action.

actionlint and zizmor pass. zizmor reports 13 more low-severity
`self-repository` notes, one per new `uses: ./...`, below the `medium`
gate like the 2 already there. The `upload` and `cleanup_packages` jobs
run only on `master` and `cron-run-tests.yaml` only on schedule or
dispatch, so their first runs after merge are the real check for them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants