security: migrate iOS secrets from UserDefaults to Keychain#41
Open
juliosuas wants to merge 1 commit intoIntent-Lab:mainfrom
Open
security: migrate iOS secrets from UserDefaults to Keychain#41juliosuas wants to merge 1 commit intoIntent-Lab:mainfrom
juliosuas wants to merge 1 commit intoIntent-Lab:mainfrom
Conversation
API keys and tokens were stored in UserDefaults, which is unencrypted and readable from device backups. This is a security risk flagged in Issue #1. Changes: - New KeychainManager.swift: thin wrapper around Security.framework for storing/retrieving sensitive strings in the iOS Keychain - SettingsManager now stores geminiAPIKey, openClawHookToken, and openClawGatewayToken in Keychain instead of UserDefaults - One-time automatic migration: existing UserDefaults secrets are moved to Keychain on first launch, then deleted from UserDefaults - Non-sensitive settings (host, port, toggles) remain in UserDefaults Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
juliosuas
pushed a commit
to juliosuas/VisionClaw
that referenced
this pull request
Apr 6, 2026
Mirrors the iOS Keychain migration (PR Intent-Lab#41). API keys and tokens were stored in plain SharedPreferences (unencrypted XML on disk). Changes: - Add androidx.security:security-crypto dependency - SettingsManager now uses EncryptedSharedPreferences (AES256-GCM) for geminiAPIKey, openClawHookToken, and openClawGatewayToken - Non-sensitive settings (host, port, toggles) remain in plain prefs - One-time auto-migration from plain prefs to encrypted on first launch - resetAll() clears both encrypted and plain storage Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
API keys and tokens (Gemini API key, OpenClaw gateway token, hook token) are stored in
UserDefaults, which is:This was flagged in Issue #1 (API key leaking) and is also relevant to PR #8 (in-app secrets management).
Fix
New:
KeychainManager.swiftThin wrapper around
Security.framework— 59 lines, zero dependencies:get(_:)/set(_:value:)/delete(_:)/deleteAll()kSecClassGenericPasswordwith a service identifierChanged:
SettingsManager.swiftMigration Behavior
Files Changed
Settings/KeychainManager.swift(new)Settings/SettingsManager.swift(modified)Test plan
plutil)🤖 Generated with Claude Code