Skip to content

Daggerfall Proofreading Project, Part 2: Quest Files#2780

Open
Mentill wants to merge 4 commits intoInterkarma:masterfrom
Mentill:quests
Open

Daggerfall Proofreading Project, Part 2: Quest Files#2780
Mentill wants to merge 4 commits intoInterkarma:masterfrom
Mentill:quests

Conversation

@Mentill
Copy link
Copy Markdown
Contributor

@Mentill Mentill commented Mar 30, 2026

This contains hundreds of corrections to spelling & grammar errors/typos in the quest files, all done by hand.
The files were also updated to implement the new upper-case gender-specific pronoun macros, my code supporting which having already been merged.

The main quest's files were gone over twice, so as to make them the most polished; going by my second pass, I probably found ~95% of the textual issues with the other quests. I also revised the new text for the updated tutorial to reduce jargon and improve accuracy.

It was recommended that I split my project into parts submitted one at a time, so this second part is just the quest files.
quests notes.txt

@KABoissonneault
Copy link
Copy Markdown
Collaborator

KABoissonneault commented Mar 30, 2026

Nice that you're still around, sorry your last change took so long to merge in. Thank you for still contributing, I'm hoping to wrap around some of the low hanging gains that we can make, and text changes are probably up there on changes that won't break the game.

For these sorts of things, I'd like to invite everyone to take a look and give their opinion on whether these changes make sense. Some of these seem like quest macros, so some quest design experience would help.

@Mentill
Copy link
Copy Markdown
Contributor Author

Mentill commented Mar 30, 2026

You're welcome. I agree rounding up the simpler changes would allow for an earlier minor release.
For reference, the relevant macros are defined in Assets/Scripts/Utility/MacroHelper.cs:

            { "%g", Pronoun },   // He/She etc...
            { "%g1", Pronoun },  // He/She ???
            { "%g2", Pronoun2 },  // Him/Her etc...
            { "%g2self", Pronoun2self },// Himself/Herself etc...
            { "%g3", Pronoun3 },  // His/Her
            { "%g4", Pronoun4 },  // His/Hers

The upper-case versions are used the same way: %G, %G1, et cetera. A few quests used incorrect macros, which I rectified.

@Daneel53
Copy link
Copy Markdown
Contributor

Daneel53 commented Apr 4, 2026

Just reread today all this stuff. This fixes many typo mistakes into the English text of quests and may be approved without any hesitation.

The only exception would be upon quest M0B40Y05 where some text is moved from message 1003 to 1004. This may seem logical because the text inside 1003 is for a successful quest and not a failed quest, but as 1003 is explicitely displayed in case of victory into the QBN part, maybe things should stay as they are. As it will be after this change, I don't know how the quest engine react to an instruction "say 1003" when 1003 is empty. Anyway this quest has a drawback (no Quest failed message) and should probably be modified to be fully correct, which is outside this proofreading project.

@Daneel53
Copy link
Copy Markdown
Contributor

Daneel53 commented Apr 5, 2026

Thanks for going back on this.

PR to be approved asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants