Replace WWW with UnityWebRequest for sound replacement#2782
Open
AncientGrief wants to merge 1 commit intoInterkarma:masterfrom
Open
Replace WWW with UnityWebRequest for sound replacement#2782AncientGrief wants to merge 1 commit intoInterkarma:masterfrom
AncientGrief wants to merge 1 commit intoInterkarma:masterfrom
Conversation
Updates the audio loading logic to use UnityWebRequestMultimedia instead of the deprecated WWW class. This implementation uses synchronous waiting to maintain compatibility with the existing architecture.
Contributor
|
I've tested the new code with both a song replacement with a .ogg file and a sound replacement with a .wav file, everything woks as expected. Replace the proposed PR 2760 that can be closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the audio loading logic to use UnityWebRequestMultimedia instead of the deprecated WWW class. This implementation uses synchronous waiting to maintain compatibility with the existing architecture.
This implementation is based around how the whole sound caching in DFU works.
It would need a little bit more effort if going the full and correct asynchronous workflow but works for now and gets rid of the warning + might also fixes #2760
Tested with .wav and .ogg replacing music and in-game sounds.