Repository navigation
Conversation
traceEvents matched SimTrace and SimPORTrace, and ended the list at any other node. A trace from controlSimTrace has TraceRacesFound nodes, so traceEvents returned only the events before the first one: of a replayed schedule, typically almost nothing. The selectTraceEvents functions already skip SimRacesFound; traceEvents now does too.
jasagredo
force-pushed
the
fix-traceEvents-races-found
branch
from
November 13, 2026 13:08
95a0764 to
71fceb0
Compare
coot
reviewed
Nov 13, 2026
Collaborator
There was a problem hiding this comment.
This fixes a symptom not the cause. The idea was that TraceRacesFound is an internal API and there's no reason to exposed it to the user. The cause of the problem is the controlSimTrace. We need a private version of controlSimTrace it which doesn't filter traces (as it's used by exploreSimTrace and a public one that filters out TraceRacesFound.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
traceEvents matched SimTrace and SimPORTrace, and ended the list at any other node. A trace from controlSimTrace has TraceRacesFound nodes, so traceEvents returned only the events before the first one: of a replayed schedule, typically almost nothing. The selectTraceEvents functions already skip SimRacesFound; traceEvents now does too.