Repository navigation
Replace the Alonzo-based eons with ShelleyBasedEra - #19
Merged
Merged
Conversation
carbolymer
changed the base branch from
master
to
mgalazyn/chore/bump-cardano-deps
November 3, 2026 11:38
carbolymer
force-pushed
the
mgalazyn/chore/remove-eons
branch
2 times, most recently
from
November 3, 2026 11:57
7d3d069 to
a30f46a
Compare
carbolymer
marked this pull request as ready for review
November 3, 2026 12:27
carbolymer
force-pushed
the
mgalazyn/chore/remove-eons
branch
from
November 3, 2026 13:31
a30f46a to
2f859a2
Compare
Jimbo4350
approved these changes
Nov 3, 2026
Jimbo4350
left a comment
There was a problem hiding this comment.
LGTM but consider the change I suggested in the comment.
Remove the AlonzoBasedEra, IsAlonzoBasedEra and ToShelleyBasedEra eons. ShelleyBasedEra is now the only era witness, and Dijkstra gets its IsShelleyBasedEra instance. Wrappers and encoders for values that exist only from Alonzo onwards take PlutusEraConstraints era. It bundles EraPlutusContext era, EraTxCert era and Script era ~ AlonzoScript era. The script equality makes the pre-Alonzo ShelleyBasedEra arms inaccessible, so matches on them list only the Alonzo-onwards eras and no arm needs an error call. The JSON output does not change. Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
Four matches in the unit tests missed a constructor and raised -Wincomplete-patterns warnings: the transaction id match in TxMonitorSpec and three UTxO matches in JsonSpec. The Dijkstra transaction id is now unwrapped like the other eras. The UTxO matches fail the test with a clear message when they decode a Dijkstra UTxO.
The ScriptPurposeIndexInAnyEra generator covered only the eras before Dijkstra. It now also produces Dijkstra purposes, which changes the seeded test vectors, so they are regenerated.
carbolymer
force-pushed
the
mgalazyn/chore/remove-eons
branch
from
November 3, 2026 16:12
2f859a2 to
ece6b41
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This answers a remark on PR #17, which asked to remove the eons as much as possible and to use
ShelleyBasedEra erawhere appropriate: #17 (comment)ShelleyBasedErais now the only era witness in the server. The JSON output does not change.What changes
AlonzoBasedEra,IsAlonzoBasedEraandToShelleyBasedEra. Dijkstra gets itsIsShelleyBasedErainstance.ShelleyBasedEra eratogether withPlutusEraConstraints era. It bundlesEraPlutusContext era,EraTxCert eraandScript era ~ AlonzoScript era.errorarms. The script equality makes GHC treat the pre-Alonzo arms as inaccessible, so writing one is a compile error.PlutusEraConstraintsis a plain constraint synonym, so no continuation-passing provider function is needed.ShelleyBasedEraconstructor, and-Werrorflags every match that misses it.-Wincomplete-patternswarnings in the unit tests. All four are missing Dijkstra cases that already exist on master.EvaluateTransactionResponsetest vectors, with no schema failures.Notes for reviewers
PlutusEraConstraintslives inOgmios.Prelude, which already disables-Wredundant-constraints.PlutusEraConstraintsis left off Alonzo's and Babbage'sencodeUtxoFailure, where nothing needs it.Testing
-Werror.There is no user-facing change, so there is no changelog entry.
This PR is stacked on PR #17, so merge it after #17: