fix(github-app): avoid PR write overprivilege#427
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
gittensory-ui | 493b443 | Commit Preview URL Branch Preview URL |
Jun 05 2026, 06:32 PM |
|
Note Gittensory Gate skippedPR closed before full evaluation. No late first comment was created.
Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers. |
This was referenced Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
pull_requests: writefor public comment/label and command-preview flows even though those surfaces use GitHub Issues API endpoints, broadening installation token privileges unnecessarily.Description
pull_requestsfromwriteback toreadinREQUIRED_INSTALLATION_PERMISSIONSby updatingsrc/github/backfill.tsto reflect the actual usage.issues: write(the Issues API) instead ofpull_requests: write.src/api/routes.tsto block public previews only whenissues: writeis missing and to stop treatingpull_requestsas a blocking permission for posting comments/labels.src/signals/settings-preview.tsto instruct operators to restoreIssues: write(notPull requests: write) for public comments/labels and command responses.pull_requests: read+issues: writebehavior.Testing
npm run typecheckand fixed a typing issue; the TypeScript build completed successfully.npm test -- --run test/unit/backfill.test.ts test/integration/api.test.ts test/unit/settings-preview.test.ts, and all tests passed.git diff --checkas a local lint/sanity check; no diff/check errors remained.Codex Task