Skip to content

fix(mcp): report source upload env in config#441

Merged
JSONbored merged 2 commits into
mainfrom
codex/fix-config-command-source-upload-reporting
Jun 6, 2026
Merged

fix(mcp): report source upload env in config#441
JSONbored merged 2 commits into
mainfrom
codex/fix-config-command-source-upload-reporting

Conversation

@JSONbored
Copy link
Copy Markdown
Owner

Motivation

  • The config command always reported source upload as disabled, which contradicted other checks that treat GITTENSORY_UPLOAD_SOURCE as an enabled-but-unsupported setting and caused confusing diagnostics.
  • The misreporting could mislead users auditing local privacy configuration even though the code still fails closed for actual uploads.

Description

  • Add sourceUploadState() to derive the source-upload posture from GITTENSORY_UPLOAD_SOURCE and return { default, enabled, source, supported } instead of a hardcoded disabled object.
  • Use sourceUploadState() in configCommand payload so JSON output reflects the env var and its source.
  • Update human-readable config output to print a warning-style message when the env var enables the unsupported behavior while preserving the disabled message when unset.
  • Update test/unit/mcp-cli.test.ts to expect the expanded sourceUpload shape and add a unit test that verifies enabled-but-unsupported reporting, and update the package README to document that config reports GITTENSORY_UPLOAD_SOURCE posture.

Testing

  • Ran the updated unit test file with npm test -- test/unit/mcp-cli.test.ts, and all tests in that file passed (48 passed).
  • Ran type checking with npm run typecheck, which succeeded.
  • Verified formatting/lint checks with git diff --check, which reported no issues.

Codex Task

@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 6, 2026
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Jun 6, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
gittensory-ui 468da15 Commit Preview URL

Branch Preview URL
Jun 06 2026, 10:39 AM

@github-actions github-actions Bot added the gittensor:bug Gittensor-scored bug fix label Jun 6, 2026
@gittensory
Copy link
Copy Markdown

gittensory Bot commented Jun 6, 2026

Note

Gittensory Gate skipped

PR closed before full evaluation. No late first comment was created.

Signal Result Evidence Action
Gate result ⚠️ Skipped #441 is no longer open. No action.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

@gittensory gittensory Bot added the gittensory:reviewed Gittensor contributor context label Jun 6, 2026
@JSONbored JSONbored self-assigned this Jun 6, 2026
@JSONbored JSONbored merged commit f37fabc into main Jun 6, 2026
10 checks passed
@JSONbored JSONbored deleted the codex/fix-config-command-source-upload-reporting branch June 6, 2026 10:42
@github-project-automation github-project-automation Bot moved this from Todo to Done in gittensory - v1 roadmap Jun 6, 2026
@github-actions github-actions Bot mentioned this pull request Jun 6, 2026
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark codex gittensor:bug Gittensor-scored bug fix gittensory:reviewed Gittensor contributor context size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant