Vecps Code Maintenance: vecps_plotter Rework#387
Open
Conversation
|
Test status for this pull request: SUCCESS Summary: /work/halld/pull_request_test/halld_sim^vecpsCodeMaintenance/tests/summary.txt Build log: /work/halld/pull_request_test/halld_sim^vecpsCodeMaintenance/make_vecpsCodeMaintenance.log |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a major rework for the vecps_plotter program. The code is now more modular and requires less user modification, reducing the need for recompilation. To highlight some of the most important changes:
-The code now parses the info from the fit file into an "amplitude registry" where all the important info is stored
-The user no longer needs to hard-code the amplitudes to be plotted. Now, every amplitude in the fit file will be plotted
-The code has logic that avoids nonphysical amp and sum combinations that would have produced an empty histogram
-The code now accepts user input that was hard-coded such as: running over a single reaction, plotting acceptance correction histograms, plotting background histograms, and producing only ROOT or txt output
-The code now has a rudimentary CSV output
PS I plan to add two features before merging: adding parameters to the text-based output and a helper function in VecPsPlotGenerator to avoid the need to modify the plotter when adding histograms.