Add IkeaLightBulbWhite device and improve motion automation dimming#85
Draft
JulianKahnert wants to merge 2 commits into
Draft
Add IkeaLightBulbWhite device and improve motion automation dimming#85JulianKahnert wants to merge 2 commits into
JulianKahnert wants to merge 2 commits into
Conversation
- Add IkeaLightBulbWhite class that overrides turnOff to use brightness control (set to 0) instead of power switch, fixing IKEA bulbs that don't turn off properly with standard turnOff - Update MotionAtNight dimming logic to check brightnessId availability before attempting to set brightness - Exclude Apps/**/.build directories from SwiftLint to avoid linting build artifacts
…chitecture documentation
JulianKahnert
force-pushed
the
feature/ikea-light-bulb-dimming-fix
branch
from
55b2757 to
f3fdc57
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IkeaLightBulbWhiteclass that overridesturnOff()to use brightness control (set to 0) instead of power switch, fixing IKEA bulbs that don't turn off properly with standardturnOffcallMotionAtNightdimming logic to checkbrightnessIdavailability before attempting to set brightness to prevent errors with devices that don't support brightness controlApps/**/.builddirectories from SwiftLint to avoid linting build artifactsChanges
Sources/HAModels/Entities/IkeaLightBulbWhite.swift- Custom device class for IKEA white light bulbsSources/HAImplementations/Automations/MotionAtNight.swift- Added brightnessId check in dimming guard statement.swiftlint.yml- Added Apps/**/.build to exclusionsTest plan