Fixes #433 - Recreates Z Data Based on Normal Map Encoding#457
Open
tvralph wants to merge 1 commit into
Open
Conversation
…map is processed by the Unity Engine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #433. Logic detects which type of normal map has been provided (e.g., DXT5) and recreates the Z component from the Unity Color class. Each file type stores Z information in a different way (or not), and it can be accessed directly or recreated based on how the information is encoded in the Unity Color class.
Issue #433 has been cited as the source of the white visual maps when using Sol (#435); however, the issues are distinct. The white maps in Sol are a shader name issue and a default to the "white" map color when nothing else triggers. (See #455). Likewise, this is also not the source of the teal/white biome colors that occur when a map is grayscale (See #452 & #456).