Repository navigation
ci: restore Windows Rust on Kiingo/buzz (M-4109) - #213
Closed
RossHartmann wants to merge 1 commit into
Closed
RossHartmann wants to merge 1 commit into
RossHartmann wants to merge 1 commit into
Conversation
Remove the temporary repository guard from #212. The refusal it worked around was not caused by the reusable workflow. #211 changed ci.yml on main while the Windows Rust jobs were still queued behind the cap-1 Windows pool, and the controller masked public_workflow_not_current as public_windows_policy_required. Kiingo/kiingo 9637404a57d now admits Windows jobs from allowlisted reusable workflows (_ci-rust.yml, _ci-desktop.yml) that are byte-identical to main. Both workflow files return to their pre-#212 content. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Ross Hartmann <rosshartmann@RosssMacStudio.attlocal.net>
Author
|
Closing: Ross paused Windows work on 2026-10-17. The M-4109 guard stays until Windows is needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts the temporary Windows Rust guard from #212. Both workflow files go back to their pre-#212 bytes. The fork-inventory change from #212 stays.
Root cause (Kiingo M-4109): the Windows refusal was not caused by the reusable workflow. Desktop Windows Build, which comes from
_ci-desktop.yml, was admitted after #204. The Rust Windows jobs were queued behind it on the cap-1 Windows pool. #211 then changedci.ymlon main at 23:11:03Z, and 10 seconds later both stale queued jobs were refused becauseci.ymlwas no longer current with main. The controller reported that aspublic_windows_policy_required, which hid the real reason.Controller (Kiingo/kiingo 9637404a57d): Windows admission now also checks every referenced reusable workflow. Each must be in this repo, pinned to the run's own commit, and byte-identical to main, with
_ci-rust.ymland_ci-desktop.ymlon the allowlist. For PRs, the merge commit must be based on main. The real refusal reason is now reported.Expected on this PR: this PR edits
ci.ymland_ci-rust.yml, so the controller's existing rule refuses its public-pool jobs aspublic_workflow_not_current. That rule only admits workflow definitions identical to main's, and it refused #212's own run the same way. Windows Rust can only go green on main's push run after this merges. Do not merge until a Kiingo owner decides.🤖 Generated with Claude Code