Repository navigation
feat(acp): keep 👀 when an adapter hands named events to an external owner (M-4017) - #217
Merged
Merged
Conversation
…wner (M-4017)
A successful session/prompt result may now carry
_meta.buzz.indicators = {"owner": "external", "eventIds": ["<event id>", ...]}
meaning the adapter handed those events' work to a durable backend that
keeps working after the ACP turn ends (for example a server-side mission
runtime that answers seconds to minutes later). The harness reconciles
exactly those messages to the seen reaction (👀) instead of clearing it,
and the backend removes it when its work ends; every other event of the
turn is cleared as before. Without the hint, or with a bare string, a
foreign owner or malformed ids, behaviour is unchanged; failed, cancelled
and retried turns ignore it. The hint is consumed once per prompt result,
so it never outlives its turn.
Kiingo's kiingo-compute-acp sets the hint only when its API holds an
active indicator for that exact event; before this, 👀 disappeared almost
immediately on mission-owned turns.
Tests authored (pool.rs, acp.rs) for CI; not run on this host.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Ross Hartmann <rosshartmann@RosssMacStudio.attlocal.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A successful session/prompt result may now carry
meaning the adapter handed those events' work to a durable backend that
keeps working after the ACP turn ends (for example a server-side mission
runtime that answers seconds to minutes later). The harness reconciles
exactly those messages to the seen reaction (👀) instead of clearing it,
and the backend removes it when its work ends; every other event of the
turn is cleared as before. Without the hint, or with a bare string, a
foreign owner or malformed ids, behaviour is unchanged; failed, cancelled
and retried turns ignore it. The hint is consumed once per prompt result,
so it never outlives its turn.
Kiingo's kiingo-compute-acp sets the hint only when its API holds an
active indicator for that exact event; before this, 👀 disappeared almost
immediately on mission-owned turns.
Tests authored (pool.rs, acp.rs) for CI; not run on this host.
Kiingo M-4017. Rebased onto main after #202 (upstream sync).
🤖 Generated with Claude Code