Repository navigation
ci: desktop CI uses Node 24.22.1 - #245
Merged
Merged
Conversation
The Windows desktop build's setup-node pin moves from 24.14.1 to 24.22.1, matching release.yml, windows-canary.yml, upstream-sync-rehearsal.yml and Hermit since #244. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Ross Hartmann <rosshartmann@RosssMacStudio.attlocal.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This follows #244. The Windows desktop build in
_ci-desktop.ymlnow usessetup-node24.22.1 instead of 24.14.1 (Node's October 21 security release). That matchesrelease.yml,windows-canary.yml,upstream-sync-rehearsal.ymland the Hermit toolchain.Expected CI result
The Windows desktop jobs will fail admission with
public_reusable_workflow_not_current. This is by design: the Spot runner admits only reusable workflows that are byte-identical to main, so a PR that changes_ci-desktop.ymlcannot run them (same as #204). #244 kept this one line out so its Windows build could run, and it passed. The first push CI on main after merge runs this workflow._ci-desktop.ymlis already classified indocs/kiingo-fork-inventory.json.🤖 Generated with Claude Code