Skip to content

docs: sync from source repos 2026-11-12 - #166

Closed
kong-volcano-app[bot] wants to merge 1 commit into
mainfrom
docs-sync/20261112-062636
Closed

kong-volcano-app[bot] wants to merge 1 commit into
mainfrom
docs-sync/20261112-062636

Conversation

@kong-volcano-app

Copy link
Copy Markdown
Contributor

Automated docs sync. Sources: docs.config.yaml.

@kong-volcano-app
kong-volcano-app Bot enabled auto-merge November 12, 2026 06:26
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions

Copy link
Copy Markdown
Contributor

AI review: 2 P0-P2 finding(s)

Reviewed 3cf4ad1. Run log

This documentation sync adds function previews, Aikido integration, and updated CLI and LavaFlow guidance. Risk is low, but two preview-guide statements misdescribe rollback retries and log retention.

🟡 P2

  • content/platform/functions/previews.md:145 Limit the rollback retry guarantee to the original revision
  • content/platform/functions/previews.md:95 Distinguish the trailing log window from log retention

Not checked: The AI review read the diff, the code, and the PR's text; it ran no tests or builds and read nothing outside this repository.

  • Whether pnpm build and the CI link and format checks pass on the assembled tree with the two new pages (functions/previews.md, guides/lavaflow-aikido.md).
  • Whether synced claims match the shipped CLI and API, such as CLI 0.76.0 uploading TypeScript and --project exiting 4 on an unknown project.
  • Confirm released CLI support for the documented preview commands and project-selection behavior, and hosting implementation of the preview, source-map, and LavaFlow contracts.
  • Verify the Aikido credential and webhook setup against a supported workspace.

Push a fix, or have a collaborator with write access (including the PR author) add the ai-review-override label to accept 3cf4ad1 as is. An override also needs a human review.

Human review: not needed


Every promotion and rollback names the serving `revision` it read, and is
refused with `stale_revision` if someone promoted or rolled back since. The CLI
reads it for you, so retrying a rollback that already applied is refused rather

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 P2: Limit the rollback retry guarantee to the original revision

Re-running volcano cloud functions rollback api after a lost successful response reads a fresh revision and can undo the rollback, as lines 135–136 describe. Only replaying the original API request with its original expected_revision produces stale_revision. Clarify this distinction so operators do not accidentally restore the preview they just removed from traffic.

Found by gpt-6.1-sol

search and streams for the function) include the code's output from the
preview for as long as it serves, under the function's ID, in one
timeline with the function's own lines. After a rollback, the preview's
lines stay in that timeline for up to 15 minutes, so calls still running at

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 P2: Distinguish the trailing log window from log retention

This says the preview's historical lines remain in the function's timeline for only 15 minutes after rollback, but lines 162–163 promise they remain until the plan's retention ends, including after preview deletion. Clarify that the 15-minute window covers additional output from in-flight calls after the switch; retained historical lines remain searchable. The current wording misleads operators investigating an older incident.

Found by gpt-6.1-sol

@kong-volcano-app

Copy link
Copy Markdown
Contributor Author

Superseded by #168.

@kong-volcano-app kong-volcano-app Bot closed this Nov 13, 2026
auto-merge was automatically disabled November 13, 2026 06:25

Pull request was closed

@kong-volcano-app
kong-volcano-app Bot deleted the docs-sync/20261112-062636 branch November 13, 2026 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant