Skip to content

docs(platform): port the LavaFlow settings docs from volcano-hosting - #171

Merged
swkeever merged 1 commit into
mainfrom
skeever/port-late-docs
Nov 13, 2026
Merged

swkeever merged 1 commit into
mainfrom
skeever/port-late-docs

Conversation

@swkeever

Copy link
Copy Markdown
Contributor

Why

#170 stopped the docs sync with a snapshot of volcano-hosting docs/public at d23abe5. One hosting PR changed docs/public after that: Kong/volcano-hosting#3396 (PATCH /lavaflow/settings accepts the dashboard session). This ports it so it isn't lost when Kong/volcano-hosting#3404 deletes docs/public.

What changed

Testing

  • pnpm lint:docs content and pnpm check:links: pass.

🤖 Generated with Claude Code

Ports the docs/public change in Kong/volcano-hosting#3396, merged after
the final snapshot in #170.
@swkeever
swkeever enabled auto-merge November 13, 2026 16:46
Copilot AI balanced review requested due to automatic review settings November 13, 2026 16:46

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The referenced hosting PR returns 404, preventing verification that dashboard sessions support owner-only LavaFlow settings updates and that this behavior is released to production.

No open issues 🎉

What changed in this PR

Ports the LavaFlow settings documentation update missed by #170’s final sync snapshot, preserving it as documentation ownership moves to this repository.

Changes:

  • Documents live Volcano dashboard sign-ins as accepted credentials for owner-only LavaFlow settings changes.
  • Updates related run-start conditions, project-token restrictions, and error guidance consistently.
File Description
content/​platform/​guides/​lavaflow.md Adds dashboard sign-in support to settings, run-start, and merging guidance.
content/​platform/​authentication/​security/​project-access-tokens.md Clarifies owner credentials while preserving project-token restrictions.
content/​platform/​api-reference/​errors.md Updates LavaFlow permission-error guidance to include dashboard sign-ins.

Review effort: Balanced

@github-actions

Copy link
Copy Markdown
Contributor

AI review: no P0-P2 findings

Reviewed 570f4aa. Run log

This is a docs-only change. It ports Kong/volcano-hosting#3396 so the LavaFlow settings guide, the errors page, and the project access token page say that a live Volcano dashboard sign-in can change LavaFlow settings, including the settings that need a person (merging, ungated workflows, turning LavaFlow on). The risk is low. One restated passage still lists only the old credentials.

⚪ P3

  • content/platform/guides/lavaflow.md:2790 "Turn Code Quality on" still lists only volcano login and expiring platform tokens

Not checked: The AI review read the diff, the code, and the PR's text; it ran no tests or builds and read nothing outside this repository.

  • That volcano-hosting 2dc8049 accepts a live dashboard session on PATCH /lavaflow/settings in every case these docs now describe (ungated workflows, merging, code_quality, turning on).
  • Whether the person_required error text quoted in errors.md ("changes the rest with a platform token") still matches what the server returns after Kong/volcano-hosting#3396.
  • Verify that the deployed Kong/volcano-hosting API supports the documented dashboard sign-ins for settings changes and runs triggered by enabling LavaFlow.

Human review: not needed

@swkeever
swkeever added this pull request to the merge queue Nov 13, 2026
Merged via the queue into main with commit 9d88a37 Nov 13, 2026
18 checks passed
@swkeever
swkeever deleted the skeever/port-late-docs branch November 13, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants