Skip to content

docs(platform): port the LavaFlow Slack and Code Quality docs from volcano-hosting - #180

Merged
swkeever merged 1 commit into
mainfrom
skeever/port-late-docs-4
Nov 13, 2026
Merged

swkeever merged 1 commit into
mainfrom
skeever/port-late-docs-4

Conversation

@swkeever

Copy link
Copy Markdown
Contributor

Why

Kong/volcano-hosting#3416 and #3418 changed docs/public after #178 ported the previous late changes. Kong/volcano-hosting#3404 deletes docs/public, so this carries both over first.

What changed

  • content/platform/guides/lavaflow.md (#3416: the dashboard sign-in for turning Code Quality on) and content/platform/guides/lavaflow-slack.md (#3418: clickable feedback and run links): the docs/public diff from volcano-hosting 10c09e6 to 65ed49d, applied as is.

Testing

  • pnpm lint:docs content and pnpm check:links: pass.

🤖 Generated with Claude Code

Copilot AI balanced review requested due to automatic review settings November 13, 2026 19:00
@swkeever
swkeever enabled auto-merge November 13, 2026 19:00

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the Code Quality authorization and Slack run-link documentation updates.

No open issues 🎉

What changed in this PR

Ports two follow-up LavaFlow documentation updates from volcano-hosting before its docs/public tree is removed, continuing the migration from #178.

Changes:

  • Documents a live Volcano dashboard sign-in as an accepted way to enable Code Quality.
  • Replaces the Slack outcome’s run ID with a Volcano run link and clarifies its environment and project-access requirements.
File Description
content/​platform/​guides/​lavaflow.md Adds dashboard sign-in to the Code Quality authorization guidance.
content/​platform/​guides/​lavaflow-slack.md Documents clickable run links and their access requirements.

Review effort: Balanced

@github-actions

Copy link
Copy Markdown
Contributor

AI review: no P0-P2 findings

Reviewed f536aa8. Run log

This is a docs-only port of two upstream volcano-hosting changes. The LavaFlow guide now lists a live Volcano dashboard sign-in as a way to turn Code Quality on, matching the "Turn merging on" section. The Slack guide now says the outcome reply links to the run in Volcano instead of giving the run's ID. The risk is low; the only finding is a small wording ambiguity.

⚪ P3

  • content/platform/guides/lavaflow-slack.md:107 "It never holds the diagnosis" now seems to refer to the run link, not the reply

Not checked: The AI review read the diff, the code, and the PR's text; it ran no tests or builds and read nothing outside this repository.

  • Whether the new text matches volcano-hosting's docs/public diff from 10c09e6 to 65ed49d exactly.
  • Whether the dashboard sign-in for Code Quality (volcano-hosting#3416) and the Slack run links (#3418) are live in production, which spec/writing.md requires before the page merges.
  • Confirm the deployed Slack integration supplies run links in the correct environment and requires project access.
  • Confirm the deployed settings API accepts live dashboard sessions when enabling Code Quality.

Human review: not needed

@swkeever
swkeever added this pull request to the merge queue Nov 13, 2026
fixed reason it opened none, and the run's ID. It never holds the diagnosis:
fixed reason it opened none, and a link to the run in Volcano. The run link
opens the report's project in the same environment as the Slack app and still
requires access to that project. It never holds the diagnosis:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚪ P3: "It never holds the diagnosis" now seems to refer to the run link, not the reply

Before this change, "It" came right after the sentence about the outcome reply, so it clearly meant the answer posted in the thread. The new sentence about the run link now sits in between. A reader can take "It" to mean the run link, which is odd because the link leads to the run where the diagnosis can be read. Naming the subject removes the ambiguity, for example "The answer never holds the diagnosis: everyone in the channel reads it, …". This text is copied as-is from upstream, so the fix may belong in volcano-hosting too.

Found by claude-opus-5-5

Merged via the queue into main with commit 46ff6d9 Nov 13, 2026
19 checks passed
@swkeever
swkeever deleted the skeever/port-late-docs-4 branch November 13, 2026 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants