Repository navigation
docs(platform): port the LavaFlow Slack and Code Quality docs from volcano-hosting - #180
Conversation
…lcano-hosting Ports the docs/public changes in Kong/volcano-hosting#3416 and #3418.
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the Code Quality authorization and Slack run-link documentation updates.
No open issues 🎉
What changed in this PR
Ports two follow-up LavaFlow documentation updates from volcano-hosting before its docs/public tree is removed, continuing the migration from #178.
Changes:
- Documents a live Volcano dashboard sign-in as an accepted way to enable Code Quality.
- Replaces the Slack outcome’s run ID with a Volcano run link and clarifies its environment and project-access requirements.
| File | Description |
|---|---|
content/platform/guides/lavaflow.md |
Adds dashboard sign-in to the Code Quality authorization guidance. |
content/platform/guides/lavaflow-slack.md |
Documents clickable run links and their access requirements. |
Review effort: Balanced
AI review: no P0-P2 findingsThis is a docs-only port of two upstream volcano-hosting changes. The LavaFlow guide now lists a live Volcano dashboard sign-in as a way to turn Code Quality on, matching the "Turn merging on" section. The Slack guide now says the outcome reply links to the run in Volcano instead of giving the run's ID. The risk is low; the only finding is a small wording ambiguity. ⚪ P3
Not checked: The AI review read the diff, the code, and the PR's text; it ran no tests or builds and read nothing outside this repository.
Human review: not needed |
| fixed reason it opened none, and the run's ID. It never holds the diagnosis: | ||
| fixed reason it opened none, and a link to the run in Volcano. The run link | ||
| opens the report's project in the same environment as the Slack app and still | ||
| requires access to that project. It never holds the diagnosis: |
There was a problem hiding this comment.
⚪ P3: "It never holds the diagnosis" now seems to refer to the run link, not the reply
Before this change, "It" came right after the sentence about the outcome reply, so it clearly meant the answer posted in the thread. The new sentence about the run link now sits in between. A reader can take "It" to mean the run link, which is odd because the link leads to the run where the diagnosis can be read. Naming the subject removes the ambiguity, for example "The answer never holds the diagnosis: everyone in the channel reads it, …". This text is copied as-is from upstream, so the fix may belong in volcano-hosting too.
Found by claude-opus-5-5
Why
Kong/volcano-hosting#3416 and #3418 changed
docs/publicafter #178 ported the previous late changes. Kong/volcano-hosting#3404 deletesdocs/public, so this carries both over first.What changed
content/platform/guides/lavaflow.md(#3416: the dashboard sign-in for turning Code Quality on) andcontent/platform/guides/lavaflow-slack.md(#3418: clickable feedback and run links): thedocs/publicdiff from volcano-hosting10c09e6to65ed49d, applied as is.Testing
pnpm lint:docs contentandpnpm check:links: pass.🤖 Generated with Claude Code