Skip to content

ci: remove the reusable lint-docs workflow - #181

Merged
swkeever merged 1 commit into
mainfrom
skeever/drop-reusable-lint
Nov 13, 2026
Merged

swkeever merged 1 commit into
mainfrom
skeever/drop-reusable-lint

Conversation

@swkeever

Copy link
Copy Markdown
Contributor

Why

The docs are now written only in this repository (#170), so no source repository lints its own docs with this repository's linter any more. The last caller, Kong/volcano-sdk-js, removed its lint-docs.yml in Kong/volcano-sdk-js#367. I checked .github/workflows/lint-docs.yml on the default branch of volcano-hosting, volcano-sdk-js, volcano-sdk-python, volcano-sdk-ruby, volcano-cli, volcano-web and volcano-builder: none has it.

What changed

  • Removed .github/workflows/lint-docs.yml (the workflow_call workflow) and .github/actions/lint-docs/ (its composite action).
  • Removed scripts/lint-docs-action.test.mjs, the test:actions script, and the CI step that ran it.
  • Dependabot no longer watches /.github/actions/*.

scripts/lint-docs.mjs is unchanged; CI still runs pnpm lint:docs content.

Testing

  • pnpm lint:docs content, pnpm test:docs: pass.
  • No reference to lint-docs.yml, actions/lint-docs, test:actions or lint-docs-action remains.

🤖 Generated with Claude Code

No source repository calls it now that the docs are written only here.
Drops the composite action, its test, the CI step and the Dependabot
directory for it.
Copilot AI balanced review requested due to automatic review settings November 13, 2026 19:23
@github-actions

Copy link
Copy Markdown
Contributor

AI review: no P0-P2 findings

Reviewed fa38b91. Run log

Removes the reusable lint-docs.yml workflow (workflow_call), its composite action under .github/actions/lint-docs/, the action's test, the test:actions script and CI step, and the Dependabot entry for /.github/actions/*. The site's own CI still runs pnpm lint:docs content. No references to the removed files remain in the head checkout, and scripts/lint-docs.mjs is unchanged. Risk is low: the only break would be an outside caller the author didn't find, and a revert would undo it.

Not checked: The AI review read the diff, the code, and the PR's text; it ran no tests or builds and read nothing outside this repository.

  • Whether any Kong repo beyond the seven the author checked still calls lint-docs.yml or actions/lint-docs@​main, including at an older ref; such a caller fails once this merges.
  • Confirm the reported removal of all external callers of the deleted workflow and composite action.

Human review: not needed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the removal of the retired cross-repository documentation lint integration.

No open issues 🎉

What changed in this PR

Completes the cleanup after #170 centralized documentation authoring in this repository, removing the lint integration previously used by product repositories. The documentation linter is unchanged, and CI retains content validation and docs-tooling tests.

Changes:

  • Removes the reusable lint workflow and its composite action.
  • Removes action-specific tests, the package script, and the corresponding CI step.
  • Stops Dependabot scanning local composite actions while retaining workflow updates.
File Description
scripts/​lint-docs-action.test.mjs Deletes tests for the retired composite action.
package.json Removes the obsolete test:actions script.
.github/​workflows/​lint-docs.yml Deletes the reusable workflow for external callers.
.github/​workflows/​ci.yml Removes the action-test step; retains docs validation.
.github/​dependabot.yml Removes composite-action scanning and updates its comment.
.github/​actions/​lint-docs/​action.yml Deletes the cross-repository lint action.

Review effort: Balanced

@swkeever
swkeever added this pull request to the merge queue Nov 13, 2026
Merged via the queue into main with commit a0d6002 Nov 13, 2026
19 checks passed
@swkeever
swkeever deleted the skeever/drop-reusable-lint branch November 13, 2026 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants