Repository navigation
Conversation
…in the step limit
Contributor
AI review: no P0-P2 findingsAdds one sentence to the build-step paragraph in Not checked: The AI review read the diff, the code, and the PR's text; it ran no tests or builds and read nothing outside this repository.
Human review: not needed |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking
VOL-1748. Companion to Kong/volcano-hosting#3172.
Why
Kong/volcano-hosting#3172 retries a dependency install that stops making progress once, within the same 30-minute step limit, instead of letting it wait out the limit. Plans and limits describes the step limit, so it should say how a stalled install is handled.
Summary
content/platform/guides/plans-and-limits.md: after the step-limit sentence, add "If a dependency install stops making progress, it is stopped and retried once within the same step limit."Merge this when Kong/volcano-hosting#3172 reaches production.
Verification
node scripts/lint-docs.mjs content/platform/guides: docs OK.