Rework pos types, add types for mark utils#1420
Open
bew wants to merge 13 commits intoL3MON4D3:masterfrom
Open
Rework pos types, add types for mark utils#1420bew wants to merge 13 commits intoL3MON4D3:masterfrom
bew wants to merge 13 commits intoL3MON4D3:masterfrom
Conversation
L3MON4D3
reviewed
Jan 18, 2026
L3MON4D3
reviewed
Jan 18, 2026
bew
commented
Jan 18, 2026
L3MON4D3
reviewed
Jan 18, 2026
L3MON4D3
reviewed
Jan 18, 2026
| ---@param p2 LuaSnip.RawPos00|LuaSnip.Pos00 | ||
| ---@return boolean | ||
| -- | ||
| -- FIXME(@bew): I don't know how to enforce the use of the same type of pos.. |
Owner
There was a problem hiding this comment.
I think it should be doable via @overload, but I'm not getting the correct results with this simple example
---@param a number
---@param b number
---@return boolean
---@overload fun(table,table) : boolean
local function test(a, b) return a == b end
test(1,{})
L3MON4D3
reviewed
Jan 18, 2026
L3MON4D3
reviewed
Jan 18, 2026
Contributor
Author
|
could we get this merged ? it's an important one to get the ball rolling ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #1396 (and reworked a little)
Mark:updatemethod (ref)